Skip tests if database and client versions do not match #2389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit skip specs if it would raise the following error: https://github.com/rsim/oracle-enhanced/actions/runs/10371897254/job/28713269701?pr=2387 ```ruby ActiveRecord::StatementInvalid: OCIError: ORA-01805: possible error in date/time operation ```
yahonda
force-pushed
the
skip_tests_if_database_and_client_versions_do_not_match
branch
from
0283a91
to
3ffb0cb
Compare
yahonda
deleted the
skip_tests_if_database_and_client_versions_do_not_match
branch
yahonda
added a commit
to yahonda/oracle-enhanced
that referenced
this pull request
Sep 22, 2024
…TCH` set to true This commit skips failing specs correctly if `DATABASE_SERVER_AND_CLIENT_VERSION_DO_NOT_MATCH` set to true Follow up rsim#2389 ```ruby $ export DATABASE_SERVER_AND_CLIENT_VERSION_DO_NOT_MATCH="true" bundle exec rspec ./spec/active_record/oracle_enhanced/type/timestamp_spec.rb ==> Loading config from ENV or use default ==> Running specs with ruby version 3.3.5 /home/yahonda/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/bundler/gems/rails-cefd9e9942c5/activesupport/lib/active_support/logger_silence.rb:5: warning: logger was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0. You can add logger to your Gemfile or gemspec to silence this warning. ==> Effective ActiveRecord version 7.1.4 ** Pending: (Failures listed here are expected and do not affect your suite's status) 1) OracleEnhancedAdapter timestamp with timezone support / TIMESTAMP WITH TIME ZONE values from ActiveRecord model should return Time value from TIMESTAMP columns # No reason given # ./spec/active_record/oracle_enhanced/type/timestamp_spec.rb:49 2) OracleEnhancedAdapter timestamp with timezone support / TIMESTAMP WITH TIME ZONE values from ActiveRecord model should return Time value with fractional seconds from TIMESTAMP columns # No reason given # ./spec/active_record/oracle_enhanced/type/timestamp_spec.rb:63 Finished in 0.00178 seconds (files took 0.53574 seconds to load) 2 examples, 0 failures, 2 pending $ ```
yahonda
added a commit
to yahonda/oracle-enhanced
that referenced
this pull request
Sep 22, 2024
…TCH` set to true This commit skips failing specs correctly if `DATABASE_SERVER_AND_CLIENT_VERSION_DO_NOT_MATCH` set to true Follow up rsim#2389 ```ruby $ export DATABASE_SERVER_AND_CLIENT_VERSION_DO_NOT_MATCH="true" bundle exec rspec ./spec/active_record/oracle_enhanced/type/timestamp_spec.rb ==> Loading config from ENV or use default ==> Running specs with ruby version 3.3.5 /home/yahonda/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/bundler/gems/rails-cefd9e9942c5/activesupport/lib/active_support/logger_silence.rb:5: warning: logger was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0. You can add logger to your Gemfile or gemspec to silence this warning. ==> Effective ActiveRecord version 7.1.4 ** Pending: (Failures listed here are expected and do not affect your suite's status) 1) OracleEnhancedAdapter timestamp with timezone support / TIMESTAMP WITH TIME ZONE values from ActiveRecord model should return Time value from TIMESTAMP columns # No reason given # ./spec/active_record/oracle_enhanced/type/timestamp_spec.rb:49 2) OracleEnhancedAdapter timestamp with timezone support / TIMESTAMP WITH TIME ZONE values from ActiveRecord model should return Time value with fractional seconds from TIMESTAMP columns # No reason given # ./spec/active_record/oracle_enhanced/type/timestamp_spec.rb:63 Finished in 0.00178 seconds (files took 0.53574 seconds to load) 2 examples, 0 failures, 2 pending $ ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request skips specs if the Oracle server and client versions do not match
https://github.com/rsim/oracle-enhanced/actions/runs/10371897254/job/28713269701?pr=2387