Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support build_explain_clause(options = []) #2394

Closed
yahonda opened this issue Sep 22, 2024 · 0 comments · Fixed by #2398
Closed

Support build_explain_clause(options = []) #2394

yahonda opened this issue Sep 22, 2024 · 0 comments · Fixed by #2398

Comments

@yahonda
Copy link
Collaborator

yahonda commented Sep 22, 2024

Steps to reproduce

$ bundle exec rspec spec/active_record/connection_adapters/oracle_enhanced_adapter_spec.rb:356

Expected behavior

It should pass without any warnings.

Actual behavior

It raises the DEPRECATION WARNING: The current database adapter, OracleEnhanced, does not support explain options. To remove this warning, the adapter must implement build_explain_clause(options = []). (called from block (3 levels) in <top (required)> at /home/yahonda/src/github.com/rsim/oracle-enhanced/spec/active_record/connection_adapters/oracle_enhanced_adapter_spec.rb:356) warning.

$ bundle exec rspec spec/active_record/connection_adapters/oracle_enhanced_adapter_spec.rb:356
==> Loading config from ENV or use default
==> Running specs with ruby version 3.3.5
/home/yahonda/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/bundler/gems/rails-cefd9e9942c5/activesupport/lib/active_support/logger_silence.rb:5: warning: logger was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.
You can add logger to your Gemfile or gemspec to silence this warning.
==> Effective ActiveRecord version 7.1.4
Run options: include {:locations=>{"./spec/active_record/connection_adapters/oracle_enhanced_adapter_spec.rb"=>[356]}}
DEPRECATION WARNING: The current database adapter, OracleEnhanced, does not support explain options. To remove this warning, the adapter must implement `build_explain_clause(options = [])`. (called from block (3 levels) in <top (required)> at /home/yahonda/src/github.com/rsim/oracle-enhanced/spec/active_record/connection_adapters/oracle_enhanced_adapter_spec.rb:356)
.

Finished in 0.79933 seconds (files took 0.53922 seconds to load)
1 example, 0 failures

$ 

System configuration

Rails version: 7.1.4

Oracle enhanced adapter version: master branch

Ruby version: ruby 3.3.5 (2024-09-03 revision ef084cc8f4) [x86_64-linux]

Oracle Database version: Oracle Database 23ai Free Release 23.0.0.0.0 - Develop, Learn, and Run for Free

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant