From 18e594c735aec5eb44fcc48194484c1e4ab70eb0 Mon Sep 17 00:00:00 2001 From: Eoghan Murray Date: Mon, 20 Feb 2023 19:06:06 +1100 Subject: [PATCH 1/2] Set userTriggered to false on Input attribute modifications - the fact we are intercepting them via hook rather than an event suggests to me that they could well be programmatic --- packages/rrweb/src/record/observer.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/rrweb/src/record/observer.ts b/packages/rrweb/src/record/observer.ts index 76a78c6fec..2360078445 100644 --- a/packages/rrweb/src/record/observer.ts +++ b/packages/rrweb/src/record/observer.ts @@ -453,7 +453,10 @@ function initInputObserver({ { set() { // mock to a normal event - eventHandler({ target: this as EventTarget } as Event); + eventHandler({ + target: this as EventTarget, + isTrusted: false, // userTriggered to false as this could well be programmatic + } as Event); }, }, false, From 16244da13fef408448e6ef33ddee4cad900667c3 Mon Sep 17 00:00:00 2001 From: Eoghan Murray Date: Fri, 3 Mar 2023 10:34:40 +0000 Subject: [PATCH 2/2] Create young-timers-grow.md --- .changeset/young-timers-grow.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/young-timers-grow.md diff --git a/.changeset/young-timers-grow.md b/.changeset/young-timers-grow.md new file mode 100644 index 0000000000..e2f9b6b76a --- /dev/null +++ b/.changeset/young-timers-grow.md @@ -0,0 +1,5 @@ +--- +"rrweb": bugfix +--- + +For users of userTriggeredOnInput setting: also set userTriggered to false on Input attribute modifications; this was previously empty this variant of IncrementalSource.Input