From 47cf7ad969d850d0e9fc249d4a27b43e5286091c Mon Sep 17 00:00:00 2001 From: Justin Halsall Date: Fri, 6 Jan 2023 11:50:04 +0100 Subject: [PATCH 1/2] Catch any errors observing iframes --- packages/rrweb/src/record/index.ts | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/packages/rrweb/src/record/index.ts b/packages/rrweb/src/record/index.ts index e40d971613..42b5d2c87d 100644 --- a/packages/rrweb/src/record/index.ts +++ b/packages/rrweb/src/record/index.ts @@ -565,7 +565,12 @@ function record( }; iframeManager.addLoadListener((iframeEl) => { - handlers.push(observe(iframeEl.contentDocument!)); + try { + handlers.push(observe(iframeEl.contentDocument!)); + } catch (error) { + // TODO: handle internal error + console.warn(error); + } }); const init = () => { From 7a21516f9c65412319eb7280356cefad7779ac54 Mon Sep 17 00:00:00 2001 From: Justin Halsall Date: Fri, 6 Jan 2023 11:51:24 +0100 Subject: [PATCH 2/2] Fix formatting --- packages/rrweb/src/index.ts | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/packages/rrweb/src/index.ts b/packages/rrweb/src/index.ts index c8b0940caa..ecc1695909 100644 --- a/packages/rrweb/src/index.ts +++ b/packages/rrweb/src/index.ts @@ -10,9 +10,7 @@ export { ReplayerEvents, } from '@rrweb/types'; -export type { - recordOptions, -} from './types'; +export type { recordOptions } from './types'; const { addCustomEvent } = record; const { freezePage } = record;