New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gofmt rules change based on Go version #4

Open

rhysh opened this issue Jun 18, 2018 · 1 comment

rhysh commented Jun 18, 2018

Hello, I'm coming here from twitchtv/twirp#114

The rules of gofmt changed in Go 1.10 and may well change again. The robot should accommodate those changes.

One option is for it to check each file against all variants of gofmt, only flagging a file if it doesn't match pass with any of them.

It sounds like @whilei may plan to address this.

Member

whilei commented Jun 18, 2018

:) #2 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment