From 42b4008ae0f59c60b5af66d7907417afbcf94c09 Mon Sep 17 00:00:00 2001 From: Michel Hidalgo Date: Thu, 24 Jun 2021 19:39:31 -0300 Subject: [PATCH 1/2] Bundle and ensure the exportation of rosidl generated targets Signed-off-by: Michel Hidalgo --- .../cmake/rosidl_typesupport_c_generate_interfaces.cmake | 3 +-- .../cmake/rosidl_typesupport_cpp_generate_interfaces.cmake | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/rosidl_typesupport_c/cmake/rosidl_typesupport_c_generate_interfaces.cmake b/rosidl_typesupport_c/cmake/rosidl_typesupport_c_generate_interfaces.cmake index c02ffddd..25bc9a11 100644 --- a/rosidl_typesupport_c/cmake/rosidl_typesupport_c_generate_interfaces.cmake +++ b/rosidl_typesupport_c/cmake/rosidl_typesupport_c_generate_interfaces.cmake @@ -156,13 +156,12 @@ add_dependencies( if(NOT rosidl_generate_interfaces_SKIP_INSTALL) install( TARGETS ${rosidl_generate_interfaces_TARGET}${_target_suffix} - EXPORT ${rosidl_generate_interfaces_TARGET}${_target_suffix} + EXPORT ${rosidl_generate_interfaces_TARGET} ARCHIVE DESTINATION lib LIBRARY DESTINATION lib RUNTIME DESTINATION bin ) ament_export_libraries(${rosidl_generate_interfaces_TARGET}${_target_suffix}) - ament_export_targets(${rosidl_generate_interfaces_TARGET}${_target_suffix}) endif() if(BUILD_TESTING AND rosidl_generate_interfaces_ADD_LINTER_TESTS) diff --git a/rosidl_typesupport_cpp/cmake/rosidl_typesupport_cpp_generate_interfaces.cmake b/rosidl_typesupport_cpp/cmake/rosidl_typesupport_cpp_generate_interfaces.cmake index 42f01c4a..cf6e5c81 100644 --- a/rosidl_typesupport_cpp/cmake/rosidl_typesupport_cpp_generate_interfaces.cmake +++ b/rosidl_typesupport_cpp/cmake/rosidl_typesupport_cpp_generate_interfaces.cmake @@ -144,13 +144,12 @@ add_dependencies( if(NOT rosidl_generate_interfaces_SKIP_INSTALL) install( TARGETS ${rosidl_generate_interfaces_TARGET}${_target_suffix} - EXPORT ${rosidl_generate_interfaces_TARGET}${_target_suffix} + EXPORT ${rosidl_generate_interfaces_TARGET} ARCHIVE DESTINATION lib LIBRARY DESTINATION lib RUNTIME DESTINATION bin ) ament_export_libraries(${rosidl_generate_interfaces_TARGET}${_target_suffix}) - ament_export_targets(${rosidl_generate_interfaces_TARGET}${_target_suffix}) endif() if(BUILD_TESTING AND rosidl_generate_interfaces_ADD_LINTER_TESTS) From 82401265de32e0130c7233f1f524e135bfb18ae2 Mon Sep 17 00:00:00 2001 From: Michel Hidalgo Date: Tue, 29 Jun 2021 12:29:02 -0300 Subject: [PATCH 2/2] Clean up dependency relationships Signed-off-by: Michel Hidalgo --- .../cmake/rosidl_typesupport_c_generate_interfaces.cmake | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/rosidl_typesupport_c/cmake/rosidl_typesupport_c_generate_interfaces.cmake b/rosidl_typesupport_c/cmake/rosidl_typesupport_c_generate_interfaces.cmake index 25bc9a11..7a3649c7 100644 --- a/rosidl_typesupport_c/cmake/rosidl_typesupport_c_generate_interfaces.cmake +++ b/rosidl_typesupport_c/cmake/rosidl_typesupport_c_generate_interfaces.cmake @@ -111,7 +111,6 @@ if(CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES "Clang") endif() target_include_directories(${rosidl_generate_interfaces_TARGET}${_target_suffix} PUBLIC - "$" "$" "$" ) @@ -143,15 +142,14 @@ foreach(_pkg_name ${rosidl_generate_interfaces_DEPENDENCY_PACKAGE_NAMES}) ament_export_dependencies(${_pkg_name}) endif() endforeach() +target_link_libraries(${rosidl_generate_interfaces_TARGET}${_target_suffix} + ${rosidl_generate_interfaces_TARGET}__rosidl_generator_c +) add_dependencies( ${rosidl_generate_interfaces_TARGET} ${rosidl_generate_interfaces_TARGET}${_target_suffix} ) -add_dependencies( - ${rosidl_generate_interfaces_TARGET}${_target_suffix} - ${rosidl_generate_interfaces_TARGET}__rosidl_generator_c -) if(NOT rosidl_generate_interfaces_SKIP_INSTALL) install(