-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add action2idl script #654
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Greek64 LGTM overall, but I will point out that in Galactic and onwards, you can also do rosidl translate --to idl path/to/my.action
I didn't know that, thanks. |
ros2/design#310 is probably the best place. Arguably, it should be replicated here. CI up to |
@Greek64 mind to alphabetise module import order? That should please |
Signed-off-by: Greek64 <greek64.mail@gmail.com>
@hidmic Done. |
CI (repos file build: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI
Thanks for the PR! |
Though the
rosidl_adapter
has scripts to generate IDL files from.msg
and.srv
files, a script for.action
files is missing.This PR rectifies that.