Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorten some excessively long lines of CMake #571

Merged
merged 1 commit into from
Feb 12, 2021

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Feb 11, 2021

The line length enforcement in ament_lint_cmake has been broken for some time, but will be fixed by ament/ament_lint#236. This change brings this package into compliance with a 120 column limit.

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

The line length enforcement in ament_lint_cmake has been broken for some
time, but will be fixed by ament/ament_lint#236. This change brings this
package into compliance with a 120 column limit.

Signed-off-by: Scott K Logan <logans@cottsay.net>
@cottsay cottsay self-assigned this Feb 11, 2021
@cottsay
Copy link
Member Author

cottsay commented Feb 11, 2021

The PR job had cmake line length test failures that will go away once we merge the detection fix along with the change to limit lines to 140 columns.

@cottsay cottsay merged commit 57befb8 into master Feb 12, 2021
@delete-merged-branch delete-merged-branch bot deleted the cottsay/cmake_line_length branch February 12, 2021 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants