Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_rosbag2_play_end_to_end flaky #408

Closed
tfoote opened this issue May 11, 2020 · 7 comments · Fixed by #1297
Closed

test_rosbag2_play_end_to_end flaky #408

tfoote opened this issue May 11, 2020 · 7 comments · Fixed by #1297
Labels
bug Something isn't working Linux Linux support tests Failing or missing tests

Comments

@tfoote
Copy link
Contributor

tfoote commented May 11, 2020

Description

The test regressed overnight.

https://ci.ros2.org/job/nightly_linux_release/1539/testReport/(root)/projectroot/test_rosbag2_play_end_to_end/

-- run_test.py: invoking following command in '/home/jenkins-agent/workspace/nightly_linux_release/ws/build/rosbag2_tests':
 - /home/jenkins-agent/workspace/nightly_linux_release/ws/build/rosbag2_tests/test_rosbag2_play_end_to_end --gtest_output=xml:/home/jenkins-agent/workspace/nightly_linux_release/ws/build/rosbag2_tests/test_results/rosbag2_tests/test_rosbag2_play_end_to_end.gtest.xml
Running main() from gmock_main.cc
[==========] Running 4 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 4 tests from PlayEndToEndTestFixture
[ RUN      ] PlayEndToEndTestFixture.play_end_to_end_test
[INFO] [1589203781.466639626] [rosbag2_storage]: Opened database 'cdr_test/cdr_test_0.db3' for READ_ONLY.
[       OK ] PlayEndToEndTestFixture.play_end_to_end_test (612 ms)
[ RUN      ] PlayEndToEndTestFixture.play_fails_gracefully_if_bag_does_not_exist
[       OK ] PlayEndToEndTestFixture.play_fails_gracefully_if_bag_does_not_exist (237 ms)
[ RUN      ] PlayEndToEndTestFixture.play_fails_gracefully_if_needed_coverter_plugin_does_not_exist
[       OK ] PlayEndToEndTestFixture.play_fails_gracefully_if_needed_coverter_plugin_does_not_exist (283 ms)
[ RUN      ] PlayEndToEndTestFixture.play_filters_by_topic
[INFO] [1589203782.518986655] [rosbag2_storage]: Opened database 'cdr_test/cdr_test_0.db3' for READ_ONLY.
[WARN] [1589203782.746890923] [rcl.logging_rosout]: Publisher already registered for provided node name. If this is due to multiple nodes with the same name then all logs for that logger name will go out over the existing publisher. As soon as any node with that name is destructed it will unregister the publisher, preventing any further logs for that name from being published on the rosout topic.
[INFO] [1589203782.999761379] [rosbag2_storage]: Opened database 'cdr_test/cdr_test_0.db3' for READ_ONLY.

Looking at the history it has failed 4 out of 7 of the last buils.

https://ci.ros2.org/job/nightly_linux_release/1539/testReport/(root)/projectroot/test_rosbag2_play_end_to_end/history/

If this cannot be resolved immediately I will plan to add an xfail flag to this to avoid busting CI and this ticket can stay open to track the failure.

This is also failing on arm64 https://ci.ros2.org/job/nightly_linux-aarch64_debug/1202/testReport/
And debug: https://ci.ros2.org/job/nightly_linux_debug/1550/testReport/(root)/projectroot/test_rosbag2_play_end_to_end/

@tfoote tfoote added the bug Something isn't working label May 11, 2020
@Karsten1987
Copy link
Collaborator

This might be fixed by #396
/cc @mabelzhang

@tfoote
Copy link
Contributor Author

tfoote commented May 14, 2020

Follow up to #396 in #410 to disable the failing test.

@wjwwood
Copy link
Member

wjwwood commented May 27, 2020

Should this be closed now?

@mabelzhang
Copy link
Contributor

We just disabled the problematic test. We could see if it can be fixed once the pause feature is in for rosbag2. I don't know if we want to leave this open until then or not.

@emersonknapp
Copy link
Collaborator

The test is currently disabled - the resolution for this ticket is to fix its stability and re-enable.

@emersonknapp
Copy link
Collaborator

We still see an occasional timeout on this test - https://github.com/ros2/rosbag2/runs/1515318271

@chapulina chapulina added Linux Linux support tests Failing or missing tests labels Apr 19, 2021
@emersonknapp emersonknapp self-assigned this Aug 13, 2021
@Crola1702
Copy link
Contributor

Crola1702 commented Jul 14, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Linux Linux support tests Failing or missing tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants