Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service_name length checks for different rmw_implementations #136

Open
rohitsalem opened this issue Apr 26, 2018 · 0 comments
Open

service_name length checks for different rmw_implementations #136

rohitsalem opened this issue Apr 26, 2018 · 0 comments
Labels
enhancement New feature or request

Comments

@rohitsalem
Copy link
Member

rohitsalem commented Apr 26, 2018

As of now checks for both the service names and topic names are same, but there should be separate length checks for service names as the service names are suffixed with a Request or a Reply in rmw_dds implementations which limits the actual length of the service names that can be used. Note: special consideration for rmw_connext implementation which suffixes the GUID of the participant to the service_name along with Reply. See: ros2/rmw_connext#285

@mikaelarguedas mikaelarguedas added the enhancement New feature or request label May 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants