Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable tests when intra process manager takes an allocator again #85

Open
wjwwood opened this issue Oct 25, 2019 · 0 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@wjwwood
Copy link
Member

wjwwood commented Oct 25, 2019

The test was disabled in #84 and it needed to be disabled because the refactored intra-process manager in rclcpp unfortunately did not have the ability to control allocations in its merged state, see:

ros2/rclcpp#778

However, the plan is update that implementation soon to again take an allocator and allow for complete control over all allocations. At that time, the disabled test should be re-enabled.

Also, at the same time it would be a good idea to refactor this test to use https://github.com/osrf/osrf_testing_tools_cpp#memory_tools instead of a custom new and delete as that approach has limitations. Also to consider how it may not work correctly for all rmw implementations, see:

#73

@wjwwood wjwwood added the bug Something isn't working label Oct 25, 2019
@wjwwood wjwwood self-assigned this Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant