Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rcpputils::fs::create_directories doesn't check if an existing path is a directory #94

Closed
christophebedard opened this issue Sep 21, 2020 · 0 comments · Fixed by #95
Closed

Comments

@christophebedard
Copy link
Member

christophebedard commented Sep 21, 2020

Calling rcpputils::fs::create_directories on /a/b/c/d, where d is a file and not a directory, will return true (assuming that /a/b/c/ exists) because it only checks that the path exists.

if (!p_built.exists()) {

One could simply call is_directory to double check, but looking at the documentation, I don't think that's right:

* \return Return true if the directory is created, false otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant