Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graph_listener error when mocking rcl_node_get_graph_guard_condition, #1341

Closed
Blast545 opened this issue Sep 28, 2020 · 2 comments
Closed
Assignees
Labels
macOS macOS support tests Failing or missing tests Windows Windows support

Comments

@Blast545
Copy link
Contributor

Blast545 commented Sep 28, 2020

I found this problem when adding coverage tests #1330. The following test is failing in Windows (and it's flaky on MacOS):

TEST_F(TestGraphListener, error_run_graph_listener_mock_get_graph_cond) {
  auto global_context = rclcpp::contexts::get_global_default_context();
  auto graph_listener_test =
    std::make_shared<TestGraphListenerProtectedMethods>(global_context);
  graph_listener_test->mock_start_thread();
  EXPECT_NO_THROW(graph_listener_test->add_node(node_graph()));
  EXPECT_NE(nullptr, node()->get_node_graph_interface()->get_graph_event());
  auto mock_wait_set_clear = mocking_utils::patch_and_return(
    "lib:rclcpp", rcl_node_get_graph_guard_condition, nullptr);
  RCLCPP_EXPECT_THROW_EQ(
    graph_listener_test->run_protected(),
    std::runtime_error("failed to get graph guard condition: error not set"));
}

Reference build: https://ci.ros2.org/job/ci_windows/12411/testReport/junit/projectroot/test/test_graph_listener/

I haven't investigated the reason yet, I'll take a look later this week.

@Blast545 Blast545 self-assigned this Sep 28, 2020
@chapulina chapulina added macOS macOS support tests Failing or missing tests Windows Windows support labels Nov 4, 2020
@CursedRock17
Copy link
Contributor

Since this test doesn't exist anymore and the draft linked to this issue was solved by #1404, this can probably be closed right?

@clalancette
Copy link
Contributor

Yeah, I'm going to close this. It is really stale, and if we come across something like this again we'll just debug it separately.

@clalancette clalancette closed this as not planned Won't fix, can't repro, duplicate, stale Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
macOS macOS support tests Failing or missing tests Windows Windows support
Projects
None yet
Development

No branches or pull requests

4 participants