Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rclcpp memory leak check via valgrind #1299

Closed
fujitatomoya opened this issue Sep 10, 2020 · 4 comments
Closed

rclcpp memory leak check via valgrind #1299

fujitatomoya opened this issue Sep 10, 2020 · 4 comments
Assignees

Comments

@fujitatomoya
Copy link
Collaborator

fujitatomoya commented Sep 10, 2020

Overview

This is a meta-ticket to manage and organize rclcpp test memory leak problems with valgrind.

Requirement

  • Check all of rclcpp test executable with valgrind.
  • List all the memory leak issue and address to each one of them.

Memory Leak List

test executable file memory leak Issue PR Description
./test_allocator_memory_strategy YES #1295 #1296 Client/Service might be memory leak
./test_create_subscription YES #1300 #1301 In SubscriptionTopicStatistics, avoid self dependency that not destoryed
./test_executors YES #1302 #1303 Clear members for StaticExecutorEntitiesCollector to avoid shared_ptr dependency
./test_loaned_message YES #1304 #1305 Test codes issue: Destroy msg extracted from LoanedMessage
./test_publisher YES     The cause is the same as test_subscription
./test_publisher_subscription_count_api YES     The cause is the same as test_subscription
./test_static_executor_entities_collector YES     The cause is the same as test_executors
./test_subscription YES #1306 #1307 Not finalize guard condition while destructing SubscriptionIntraProcess
./test_subscription_options YES     The cause is the same as test_create_subscription
./test_subscription_topic_statistics YES     The cause is the same as test_create_subscription
@fujitatomoya
Copy link
Collaborator Author

CC: @Barry-Xu-2018 @iuhilnehc-ynos

@Barry-Xu-2018
Copy link
Collaborator

Barry-Xu-2018 commented Sep 11, 2020

@fujitatomoya @iuhilnehc-ynos

Thanks for creating this ticket.

Currently, we execute rclcpp test and find below memory leak cases.
rcl: 511fc40
rclcpp: 01d6f52
rmw_fastrtps_cpp: bbe2ac2e3e63c145e9dabd4f073c62d672521a57

test executable file memory leak Issue PR Description
./test_allocator_memory_strategy YES #1295 #1296 Client/Service might be memory leak
./test_create_subscription YES #1300 #1301 In SubscriptionTopicStatistics, avoid self dependency that not destoryed
./test_executors YES #1302 #1303 Clear members for StaticExecutorEntitiesCollector to avoid shared_ptr dependency
./test_loaned_message YES #1304 #1305 Test codes issue: Destroy msg extracted from LoanedMessage
./test_publisher YES The cause is the same as test_subscription
./test_publisher_subscription_count_api YES The cause is the same as test_subscription
./test_static_executor_entities_collector YES The cause is the same as test_executors
./test_subscription YES #1306 #1307 Not finalize guard condition while destructing SubscriptionIntraProcess
./test_subscription_options YES The cause is the same as test_create_subscription
./test_subscription_topic_statistics YES The cause is the same as test_create_subscription

@fujitatomoya
Copy link
Collaborator Author

@Barry-Xu-2018

i think everything's been addressed by now, could you confirm and help to close this one?

@Barry-Xu-2018
Copy link
Collaborator

@fujitatomoya

Yeah. Please close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants