From ebc5ac5b92d810c12114a9eafbb8cb9aaca4c5f1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alejandro=20Hern=C3=A1ndez=20Cordero?= Date: Wed, 30 Sep 2020 16:15:35 +0200 Subject: [PATCH] Improved test_subscription_options (#1358) * Improved test_subscription_options Signed-off-by: ahcorde * used RCLCPP_EXPECT_THROW_EQ in test_subcription_options Signed-off-by: ahcorde * make linters happy Signed-off-by: ahcorde --- rclcpp/test/rclcpp/test_subscription_options.cpp | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/rclcpp/test/rclcpp/test_subscription_options.cpp b/rclcpp/test/rclcpp/test_subscription_options.cpp index ee24685dca..c4cfb6b4c4 100644 --- a/rclcpp/test/rclcpp/test_subscription_options.cpp +++ b/rclcpp/test/rclcpp/test_subscription_options.cpp @@ -23,6 +23,8 @@ #include "rclcpp/node_options.hpp" #include "rclcpp/subscription_options.hpp" +#include "../utils/rclcpp_gtest_macros.hpp" + using namespace std::chrono_literals; namespace @@ -85,4 +87,17 @@ TEST_F(TestSubscriptionOptions, topic_statistics_options_node_default_mode) { rclcpp::detail::resolve_enable_topic_statistics( subscription_options, *(node->get_node_base_interface()))); + + subscription_options.topic_stats_options.state = rclcpp::TopicStatisticsState::Disable; + EXPECT_FALSE( + rclcpp::detail::resolve_enable_topic_statistics( + subscription_options, + *(node->get_node_base_interface()))); + + subscription_options.topic_stats_options.state = static_cast(5); + RCLCPP_EXPECT_THROW_EQ( + rclcpp::detail::resolve_enable_topic_statistics( + subscription_options, + *(node->get_node_base_interface())), + std::runtime_error("Unrecognized EnableTopicStatistics value")); }