From f299c604d14fd79e87cc5d777578463ed3166058 Mon Sep 17 00:00:00 2001 From: Christophe Bedard Date: Fri, 19 Jun 2020 16:49:30 -0400 Subject: [PATCH 1/8] Update tracetools' QL to 2 in rcl's QD (#690) Signed-off-by: Christophe Bedard --- rcl/QUALITY_DECLARATION.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rcl/QUALITY_DECLARATION.md b/rcl/QUALITY_DECLARATION.md index 9ed4c248f..b7570e4ec 100644 --- a/rcl/QUALITY_DECLARATION.md +++ b/rcl/QUALITY_DECLARATION.md @@ -185,7 +185,7 @@ It is **Quality Level 4**, see its [Quality Declaration document](https://github The `tracetools` package provides utilities for instrumenting the code in `rcl` so that it may be traced for debugging and performance analysis. -It is **Quality Level 4**, see its [Quality Declaration document](https://gitlab.com/micro-ROS/ros_tracing/ros2_tracing/-/blob/master/tracetools/QUALITY_DECLARATION.md). +It is **Quality Level 2**, see its [Quality Declaration document](https://gitlab.com/micro-ROS/ros_tracing/ros2_tracing/-/blob/master/tracetools/QUALITY_DECLARATION.md). ### Optional Direct Runtime ROS Dependencies [5.ii] From fa4e9c690af0b0e6c54a300b2cb5024a07e447c7 Mon Sep 17 00:00:00 2001 From: Jorge Perez Date: Mon, 22 Jun 2020 16:39:59 -0300 Subject: [PATCH 2/8] Fix link to latest API docs (#692) Signed-off-by: Jorge Perez --- rcl/QUALITY_DECLARATION.md | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/rcl/QUALITY_DECLARATION.md b/rcl/QUALITY_DECLARATION.md index b7570e4ec..2c9a0de51 100644 --- a/rcl/QUALITY_DECLARATION.md +++ b/rcl/QUALITY_DECLARATION.md @@ -71,7 +71,7 @@ All pull requests must resolve related documentation changes before merging. ### Public API Documentation [3.ii] -`rcl` has embedded API documentation and it is generated using doxygen. Currently, its eloquent version is hosted [here](http://docs.ros2.org/eloquent/api/rcl/). Latest version has to be generated before considering this item fully resolved. +`rcl` has embedded API documentation and it is generated using doxygen. Currently, its latest version is hosted [here](http://docs.ros2.org/latest/api/rcl/). New additions to the public API require documentation before being added. @@ -213,7 +213,7 @@ The chart below compares the requirements in the REP-2004 with the current state |--|--|--| |1| **Version policy** |---| |1.i|Version Policy available | ✓ | -|1.ii|Stable version |☓| +|1.ii|Stable version |✓| |1.iii|Declared public API|✓| |1.iv|API stability policy|✓| |1.v|ABI stability policy|✓| @@ -225,8 +225,8 @@ The chart below compares the requirements in the REP-2004 with the current state |2.iv| CI policy for change requests | ✓ | |2.v| Documentation policy for change requests | ✓ | |3| **Documentation** | --- | -|3.i| Per feature documentation | ☓ | -|3.ii| Per public API item documentation | * | +|3.i| Per feature documentation | ✓ | +|3.ii| Per public API item documentation | ✓ | |3.iii| Declared License(s) | ✓ | |3.iv| Copyright in source files| ✓ | |3.v.a| Quality declaration linked to README | ✓ | @@ -234,7 +234,7 @@ The chart below compares the requirements in the REP-2004 with the current state |4| Testing | --- | |4.i| Feature items tests | ✓ | |4.ii| Public API tests | ✓ | -|4.iii.a| Using coverage | * | +|4.iii.a| Using coverage | ✓ | |4.iii.a| Coverage policy | ✓ | |4.iv.a| Performance tests (if applicable) | ☓ | |4.iv.b| Performance tests policy| ✓ | @@ -247,4 +247,4 @@ The chart below compares the requirements in the REP-2004 with the current state |6| Platform support | --- | |6.i| Support targets Tier1 ROS platforms| ✓ | |7| Security | --- | -|7.i| Vulnerability Disclosure Policy | ☓ | +|7.i| Vulnerability Disclosure Policy | ✓ | From e5fbbb426997b9028b5779ff3807a21534ddec9e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alejandro=20Hern=C3=A1ndez=20Cordero?= Date: Mon, 29 Jun 2020 18:58:18 +0200 Subject: [PATCH 3/8] Update quality declaration and coverage (#674) * Update quality level and coverage Signed-off-by: ahcorde * Added feedback Signed-off-by: ahcorde * Fixed wording and links Signed-off-by: ahcorde * Updated QD Signed-off-by: ahcorde --- rcl/QUALITY_DECLARATION.md | 10 ++++--- rcl/README.md | 2 +- rcl_action/QUALITY_DECLARATION.md | 28 +++++++++++++----- rcl_action/README.md | 2 +- rcl_lifecycle/QUALITY_DECLARATION.md | 26 ++++++++++++---- rcl_lifecycle/README.md | 2 +- rcl_yaml_param_parser/QUALITY_DECLARATION.md | 31 +++++++++++++++----- rcl_yaml_param_parser/README.md | 2 +- 8 files changed, 76 insertions(+), 27 deletions(-) diff --git a/rcl/QUALITY_DECLARATION.md b/rcl/QUALITY_DECLARATION.md index 2c9a0de51..021503a95 100644 --- a/rcl/QUALITY_DECLARATION.md +++ b/rcl/QUALITY_DECLARATION.md @@ -2,7 +2,7 @@ This document is a declaration of software quality for the `rcl` package, based # `rcl` Quality Declaration -The package `rcl` claims to be in the **Quality Level 4** category. +The package `rcl` claims to be in the **Quality Level 3** category. Below are the rationales, notes, and caveats for this claim, organized by each requirement listed in the [Package Quality Categories in REP-2004](https://index.ros.org/doc/ros2/Contributing/Developer-Guide/#package-quality-categories). @@ -101,7 +101,9 @@ Currently nightly test results can be seen here: ### Public API Testing [4.ii] -Most of the functionality of the declared API in this package is covered in its unit tests. Currently it has a line coverage of [77%](https://ci.ros2.org/job/ci_linux_coverage/85/cobertura/src_ros2_rcl_rcl_src_rcl/). +Each part of the public API has tests, and new additions or changes to the public API require tests before being added. The tests aim to cover both typical usage and corner cases, but are quantified by contributing to code coverage. + +The following functions are partially supported: `rcl_take_loaned_message`, `rcl_return_loaned_message_from_subscription`, `rcl_borrow_loaned_message`, `rcl_return_loaned_message_from_publisher` and `rcl_publish_loaned_message` because they are not currently supported on Tier 1 RMW providers. ### Coverage [4.iii] @@ -114,7 +116,7 @@ This includes: Changes are required to make a best effort to keep or increase coverage before being accepted, but decreases are allowed if properly justified and accepted by reviewers. -Current coverage statistics can be viewed (77%) [here](https://ci.ros2.org/job/ci_linux_coverage/85/cobertura/src_ros2_rcl_rcl_src_rcl/). Current coverage statistics need to be improved to reach a higher quality level. +Current coverage statistics can be viewed [here](https://ci.ros2.org/job/nightly_linux_coverage/lastSuccessfulBuild/cobertura/src_ros2_rcl_rcl_src_rcl/). A description of how coverage statistics are calculated is summarized in this page ["ROS 2 Onboarding Guide"](https://index.ros.org/doc/ros2/Contributing/ROS-2-On-boarding-Guide/#note-on-coverage-runs). ### Performance [4.iv] @@ -167,7 +169,7 @@ It is **Quality Level 4**, see its [Quality Declaration document](https://github The `rcutils` package provides an API which contains common utilities and data structures needed when programming in C. -It is **Quality Level 4**, see its [Quality Declaration document](https://github.com/ros2/rcutils/blob/master/QUALITY_DECLARATION.md). +It is **Quality Level 2**, see its [Quality Declaration document](https://github.com/ros2/rcutils/blob/master/QUALITY_DECLARATION.md). #### `rmw_implementation` diff --git a/rcl/README.md b/rcl/README.md index c7f778382..c602d8044 100644 --- a/rcl/README.md +++ b/rcl/README.md @@ -4,4 +4,4 @@ Library to support implementation of language specific ROS Client Libraries. Features are described in detail at [http://docs.ros2.org](http://docs.ros2.org/latest/api/rcl/index.html) -This package claims to be in the **Quality Level 4** category, see the [Quality Declaration](./QUALITY_DECLARATION.md) for more details. +This package claims to be in the **Quality Level 3** category, see the [Quality Declaration](./QUALITY_DECLARATION.md) for more details. diff --git a/rcl_action/QUALITY_DECLARATION.md b/rcl_action/QUALITY_DECLARATION.md index 7dec8d8f9..9966b2a86 100644 --- a/rcl_action/QUALITY_DECLARATION.md +++ b/rcl_action/QUALITY_DECLARATION.md @@ -2,9 +2,9 @@ This document is a declaration of software quality for the `rcl_action` package, # `rcl_action` Quality Declaration -The package `rcl_action` claims to be in the **Quality Level 4** category. +The package `rcl_action` claims to be in the **Quality Level 3** category. -Below are the rationales, notes, and caveats for this claim, organized by each requirement listed in the [Package Requirements for Quality Level 4 in REP-2004](https://www.ros.org/reps/rep-2004.html). +Below are the rationales, notes, and caveats for this claim, organized by each requirement listed in the [Package Quality Categories in REP-2004](https://index.ros.org/doc/ros2/Contributing/Developer-Guide/#package-quality-categories). ## Version Policy [1] @@ -88,15 +88,29 @@ The results of the test can be found [here](https://ci.ros2.org/view/nightly/job `rcl_action` has feature tests, which test for proper node state transitions. The tests are located in the [test](test) subdirectory. +New features are required to have tests before being added. +Currently nightly test results can be seen here: +* [linux-aarch64_release](https://ci.ros2.org/view/nightly/job/nightly_linux-aarch64_release/lastBuild/testReport/rcl_action/) +* [linux_release](https://ci.ros2.org/view/nightly/job/nightly_linux_release/lastBuild/testReport/rcl_action/) +* [mac_osx_release](https://ci.ros2.org/view/nightly/job/nightly_osx_release/lastBuild/testReport/rcl_action/) +* [windows_release](https://ci.ros2.org/view/nightly/job/nightly_win_rel/lastBuild/testReport/rcl_action/) ### Public API Testing [4.ii] -Much of the API in `rcl_action` is tested. -The tests are located in the [test](test) subdirectory. +Each part of the public API has tests, and new additions or changes to the public API require tests before being added. The tests aim to cover both typical usage and corner cases, but are quantified by contributing to code coverage. ### Coverage [4.iii] -`rcl_action` does not currently track test coverage. +`rcl_action` follows the recommendations for ROS Core packages in the [ROS 2 Developer Guide](https://index.ros.org/doc/ros2/Contributing/Developer-Guide/#code-coverage), and opts to use line coverage instead of branch coverage. + +This includes: + +- tracking and reporting line coverage statistics +- no lines are manually skipped in coverage calculations + +Changes are required to make a best effort to keep or increase coverage before being accepted, but decreases are allowed if properly justified and accepted by reviewers. + +Current coverage statistics can be viewed [here](https://ci.ros2.org/job/nightly_linux_coverage/lastSuccessfulBuild/cobertura/src_ros2_rcl_rcl_action_src_rcl_action/). A description of how coverage statistics are calculated is summarized in this page ["ROS 2 Onboarding Guide"](https://index.ros.org/doc/ros2/Contributing/ROS-2-On-boarding-Guide/#note-on-coverage-runs). ### Performance [4.iv] @@ -129,13 +143,13 @@ It is **Quality Level 4**, see its [Quality Declaration document](https://github `rcl` is the ROS 2 client library in C. -It is **Quality Level 4**, see its [Quality Declaration document](../rcl/QUALITY_DECLARATION). +It is **Quality Level 3**, see its [Quality Declaration document](../rcl/QUALITY_DECLARATION). #### `rcutils` `rcutils` provides commonly used functionality in C. -It is **Quality Level 4**, see its [Quality Declaration document](https://github.com/ros2/rcutils/blob/master/QUALITY_DECLARATION.md). +It is **Quality Level 2**, see its [Quality Declaration document](https://github.com/ros2/rcutils/blob/master/QUALITY_DECLARATION.md). #### `rmw` diff --git a/rcl_action/README.md b/rcl_action/README.md index bd9e26745..2f74f5b08 100644 --- a/rcl_action/README.md +++ b/rcl_action/README.md @@ -9,4 +9,4 @@ http://design.ros2.org/articles/actions.html ## Quality Declaration -This package claims to be in the **Quality Level 4** category, see the [Quality Declaration](./QUALITY_DECLARATION.md) for more details. +This package claims to be in the **Quality Level 3** category, see the [Quality Declaration](./QUALITY_DECLARATION.md) for more details. diff --git a/rcl_lifecycle/QUALITY_DECLARATION.md b/rcl_lifecycle/QUALITY_DECLARATION.md index 933d0be17..837996f96 100644 --- a/rcl_lifecycle/QUALITY_DECLARATION.md +++ b/rcl_lifecycle/QUALITY_DECLARATION.md @@ -2,9 +2,9 @@ This document is a declaration of software quality for the `rcl_lifecycle` packa # `rcl_lifecycle` Quality Declaration -The package `rcl_lifecycle` claims to be in the **Quality Level 4** category. +The package `rcl_lifecycle` claims to be in the **Quality Level 3** category. -Below are the rationales, notes, and caveats for this claim, organized by each requirement listed in the [Package Requirements for Quality Level 4 in REP-2004](https://www.ros.org/reps/rep-2004.html). +Below are the rationales, notes, and caveats for this claim, organized by each requirement listed in the [Package Quality Categories in REP-2004](https://index.ros.org/doc/ros2/Contributing/Developer-Guide/#package-quality-categories). ## Version Policy [1] @@ -88,14 +88,30 @@ The results of the test can be found [here](https://ci.ros2.org/view/nightly/job `rcl_lifecycle` has feature tests, which test for proper node state transitions. The tests are located in the [test](test) subdirectory. +New features are required to have tests before being added. +Currently nightly test results can be seen here: +* [linux-aarch64_release](https://ci.ros2.org/view/nightly/job/nightly_linux-aarch64_release/lastBuild/testReport/rcl_lifecycle/) +* [linux_release](https://ci.ros2.org/view/nightly/job/nightly_linux_release/lastBuild/testReport/rcl_lifecycle/) +* [mac_osx_release](https://ci.ros2.org/view/nightly/job/nightly_osx_release/lastBuild/testReport/rcl_lifecycle/) +* [windows_release](https://ci.ros2.org/view/nightly/job/nightly_win_rel/lastBuild/testReport/rcl_lifecycle/) + ### Public API Testing [4.ii] -Much of the API in `rcl_lifecycle` is tested in the aforementioned feature tests, but it is not tested explicitly. +Each part of the public API has tests, and new additions or changes to the public API require tests before being added. The tests aim to cover both typical usage and corner cases, but are quantified by contributing to code coverage. ### Coverage [4.iii] -`rcl_lifecycle` does not currently track test coverage. +`rcl_lifecycle` follows the recommendations for ROS Core packages in the [ROS 2 Developer Guide](https://index.ros.org/doc/ros2/Contributing/Developer-Guide/#code-coverage), and opts to use line coverage instead of branch coverage. + +This includes: + +- tracking and reporting line coverage statistics +- no lines are manually skipped in coverage calculations + +Changes are required to make a best effort to keep or increase coverage before being accepted, but decreases are allowed if properly justified and accepted by reviewers. + +Current coverage statistics can be viewed [here](https://ci.ros2.org/job/nightly_linux_coverage/lastSuccessfulBuild/cobertura/src_ros2_rcl_rcl_lifecycle_src/). A description of how coverage statistics are calculated is summarized in this page ["ROS 2 Onboarding Guide"](https://index.ros.org/doc/ros2/Contributing/ROS-2-On-boarding-Guide/#note-on-coverage-runs). ### Performance [4.iv] @@ -128,7 +144,7 @@ It is **Quality Level 4**, see its [Quality Declaration document](https://github `rcl` is the ROS 2 client library in C. -It is **Quality Level 4**, see its [Quality Declaration document](../rcl/QUALITY_DECLARATION). +It is **Quality Level 3**, see its [Quality Declaration document](../rcl/QUALITY_DECLARATION). #### `rcutils` diff --git a/rcl_lifecycle/README.md b/rcl_lifecycle/README.md index e6fabf07b..a161d0806 100644 --- a/rcl_lifecycle/README.md +++ b/rcl_lifecycle/README.md @@ -9,4 +9,4 @@ https://design.ros2.org/articles/node_lifecycle.html ## Quality Declaration -This package claims to be in the **Quality Level 4** category, see the [Quality Declaration](./QUALITY_DECLARATION.md) for more details. +This package claims to be in the **Quality Level 3** category, see the [Quality Declaration](./QUALITY_DECLARATION.md) for more details. diff --git a/rcl_yaml_param_parser/QUALITY_DECLARATION.md b/rcl_yaml_param_parser/QUALITY_DECLARATION.md index aa3f4bbac..f42929085 100644 --- a/rcl_yaml_param_parser/QUALITY_DECLARATION.md +++ b/rcl_yaml_param_parser/QUALITY_DECLARATION.md @@ -2,9 +2,9 @@ This document is a declaration of software quality for the `rcl_yaml_param_parse # `rcl_yaml_param_parser` Quality Declaration -The package `rcl_yaml_param_parser` claims to be in the **Quality Level 4** category. +The package `rcl_yaml_param_parser` claims to be in the **Quality Level 3** category. -Below are the rationales, notes, and caveats for this claim, organized by each requirement listed in the [Package Requirements for Quality Level 4 in REP-2004](https://www.ros.org/reps/rep-2004.html). +Below are the rationales, notes, and caveats for this claim, organized by each requirement listed in the [Package Quality Categories in REP-2004](https://index.ros.org/doc/ros2/Contributing/Developer-Guide/#package-quality-categories). ## Version Policy [1] @@ -59,10 +59,12 @@ All pull requests must resolve related documentation changes before merging. ### Feature Documentation [3.i] -`rcl_yaml_param_parser` does not have feature documentation. +`rcl_yaml_param_parser` provides the main elements of its API listed using doxygen and is hosted [here](http://docs.ros2.org/latest/api/rcl_yaml_param_parser/index.html). ### Public API Documentation [3.ii] +`rcl_yaml_param_parser` has embedded API documentation and it is generated using doxygen. Currently, its latest version is hosted [here](http://docs.ros2.org/latest/api/rcl_yaml_param_parser/index.html). Latest version has to be generated before considering this item fully resolved. + All of `rcl_yaml_param_parser` has embedded API documentation. It is not yet hosted publicly. ### License [3.iii] @@ -85,15 +87,30 @@ The results of the test can be found [here](https://ci.ros2.org/view/nightly/job ### Feature Testing [4.i] -`rcl_yaml_param_parser` has feature tests, which ensure that a wide variety of yaml files are checked for parsing. +Most features in `rcl_yaml_param_parser` have corresponding tests which simulate typical usage, and they are located in the [`test`](./test) directory. +New features are required to have tests before being added. +Currently nightly test results can be seen here: +* [linux-aarch64_release](https://ci.ros2.org/view/nightly/job/nightly_linux-aarch64_release/lastBuild/testReport/rcl_yaml_param_parser/) +* [linux_release](https://ci.ros2.org/view/nightly/job/nightly_linux_release/lastBuild/testReport/rcl_yaml_param_parser/) +* [mac_osx_release](https://ci.ros2.org/view/nightly/job/nightly_osx_release/lastBuild/testReport/rcl_yaml_param_parser/) +* [windows_release](https://ci.ros2.org/view/nightly/job/nightly_win_rel/lastBuild/testReport/rcl_yaml_param_parser/) ### Public API Testing [4.ii] -Much of the API in `rcl_yaml_param_parser` is tested in the aforementioned feature tests, but it is not tested explicitly. +Each part of the public API has tests, and new additions or changes to the public API require tests before being added. The tests aim to cover both typical usage and corner cases, but are quantified by contributing to code coverage. ### Coverage [4.iii] -`rcl_yaml_param_parser` does not currently track test coverage. +`rcl_yaml_param_parser` follows the recommendations for ROS Core packages in the [ROS 2 Developer Guide](https://index.ros.org/doc/ros2/Contributing/Developer-Guide/#code-coverage), and opts to use line coverage instead of branch coverage. + +This includes: + +- tracking and reporting line coverage statistics +- no lines are manually skipped in coverage calculations + +Changes are required to make a best effort to keep or increase coverage before being accepted, but decreases are allowed if properly justified and accepted by reviewers. + +Current coverage statistics can be viewed [here](https://ci.ros2.org/job/nightly_linux_coverage/lastSuccessfulBuild/cobertura/src_ros2_rcl_rcl_yaml_param_parser_src/). A description of how coverage statistics are calculated is summarized in this page ["ROS 2 Onboarding Guide"](https://index.ros.org/doc/ros2/Contributing/ROS-2-On-boarding-Guide/#note-on-coverage-runs). ### Performance [4.iv] @@ -118,7 +135,7 @@ It also has several test dependencies, which do not affect the resulting quality `rcutils` provides commonly used functionality in C. -It is **Quality Level 4**, see its [Quality Declaration document](https://github.com/ros2/rcutils/blob/master/QUALITY_DECLARATION.md). +It is **Quality Level 3**, see its [Quality Declaration document](https://github.com/ros2/rcutils/blob/master/QUALITY_DECLARATION.md). #### `libyaml_vendor` diff --git a/rcl_yaml_param_parser/README.md b/rcl_yaml_param_parser/README.md index 7e571045c..e402a1eb6 100644 --- a/rcl_yaml_param_parser/README.md +++ b/rcl_yaml_param_parser/README.md @@ -30,4 +30,4 @@ This package depends on C libyaml. ## Quality Declaration -This package claims to be in the **Quality Level 4** category, see the [Quality Declaration](./QUALITY_DECLARATION.md) for more details. +This package claims to be in the **Quality Level 3** category, see the [Quality Declaration](./QUALITY_DECLARATION.md) for more details. From de0256ad8c52f8c90a1782a970f07e3633ce2a6a Mon Sep 17 00:00:00 2001 From: ahcorde Date: Tue, 27 Oct 2020 15:20:34 +0100 Subject: [PATCH 4/8] udpate QD links to foxy Signed-off-by: ahcorde --- rcl/QUALITY_DECLARATION.md | 12 ++++++------ rcl_action/QUALITY_DECLARATION.md | 8 ++++---- rcl_lifecycle/QUALITY_DECLARATION.md | 8 ++++---- rcl_yaml_param_parser/QUALITY_DECLARATION.md | 6 +++--- 4 files changed, 17 insertions(+), 17 deletions(-) diff --git a/rcl/QUALITY_DECLARATION.md b/rcl/QUALITY_DECLARATION.md index 021503a95..ac7f14d77 100644 --- a/rcl/QUALITY_DECLARATION.md +++ b/rcl/QUALITY_DECLARATION.md @@ -151,7 +151,7 @@ It is **Quality Level 4**, see its [Quality Declaration document](https://github The `rcl_interfaces` package provides some common ROS Message and ROS Service types which are used to implement certain client library features. -It is **Quality Level 4**, see its [Quality Declaration document](https://github.com/ros2/rcl_interfaces/blob/master/rcl_interfaces/QUALITY_DECLARATION.md). +It is **Quality Level 4**, see its [Quality Declaration document](https://github.com/ros2/rcl_interfaces/blob/foxy/rcl_interfaces/QUALITY_DECLARATION.md). #### `rcl_logging_spdlog` @@ -163,31 +163,31 @@ It is **Quality Level 4**, see its [Quality Declaration document](https://github The `rcl_yaml_param_parser` package provides an API that is used to parse YAML configuration files which may be used to configure ROS and specific nodes. -It is **Quality Level 4**, see its [Quality Declaration document](https://github.com/ros2/rcl/tree/master/rcl_yaml_param_parser/Quality_Declaration.md). +It is **Quality Level 4**, see its [Quality Declaration document](https://github.com/ros2/rcl/tree/foxy/rcl_yaml_param_parser/Quality_Declaration.md). #### `rcutils` The `rcutils` package provides an API which contains common utilities and data structures needed when programming in C. -It is **Quality Level 2**, see its [Quality Declaration document](https://github.com/ros2/rcutils/blob/master/QUALITY_DECLARATION.md). +It is **Quality Level 2**, see its [Quality Declaration document](https://github.com/ros2/rcutils/blob/foxy/QUALITY_DECLARATION.md). #### `rmw_implementation` The `rmw_implementation` package provides access to the default rmw implementation, and provides the ability to dynamically switch rmw implementations if more than one is available. -It is **Quality Level 4**, see its [Quality Declaration document](https://github.com/ros2/rmw_implementation/blob/master/QUALITY_DECLARATION.md). +It is **Quality Level 4**, see its [Quality Declaration document](https://github.com/ros2/rmw_implementation/blob/foxy/QUALITY_DECLARATION.md). #### `rosidl_runtime_c` The `rosidl_runtime_c` package provides runtime interfaces in C based on user defined ROS Messages and ROS Services, as well as associated support functions for those types. -It is **Quality Level 4**, see its [Quality Declaration document](https://github.com/ros2/rosidl/tree/master/rosidl_runtime_c/Quality_Declaration.md). +It is **Quality Level 4**, see its [Quality Declaration document](https://github.com/ros2/rosidl/tree/foxy/rosidl_runtime_c/Quality_Declaration.md). #### `tracetools` The `tracetools` package provides utilities for instrumenting the code in `rcl` so that it may be traced for debugging and performance analysis. -It is **Quality Level 2**, see its [Quality Declaration document](https://gitlab.com/micro-ROS/ros_tracing/ros2_tracing/-/blob/master/tracetools/QUALITY_DECLARATION.md). +It is **Quality Level 2**, see its [Quality Declaration document](https://gitlab.com/micro-ROS/ros_tracing/ros2_tracing/-/blob/foxy/tracetools/QUALITY_DECLARATION.md). ### Optional Direct Runtime ROS Dependencies [5.ii] diff --git a/rcl_action/QUALITY_DECLARATION.md b/rcl_action/QUALITY_DECLARATION.md index 9966b2a86..69e995a87 100644 --- a/rcl_action/QUALITY_DECLARATION.md +++ b/rcl_action/QUALITY_DECLARATION.md @@ -137,7 +137,7 @@ It also has several test dependencies, which do not affect the resulting quality `action_msgs` provides messages and services for ROS 2 actions. -It is **Quality Level 4**, see its [Quality Declaration document](https://github.com/ros2/rcl_interfaces/blob/master/action_msgs/QUALITY_DECLARATION.md). +It is **Quality Level 4**, see its [Quality Declaration document](https://github.com/ros2/rcl_interfaces/blob/foxy/action_msgs/QUALITY_DECLARATION.md). #### `rcl` @@ -149,19 +149,19 @@ It is **Quality Level 3**, see its [Quality Declaration document](../rcl/QUALITY `rcutils` provides commonly used functionality in C. -It is **Quality Level 2**, see its [Quality Declaration document](https://github.com/ros2/rcutils/blob/master/QUALITY_DECLARATION.md). +It is **Quality Level 2**, see its [Quality Declaration document](https://github.com/ros2/rcutils/blob/foxy/QUALITY_DECLARATION.md). #### `rmw` `rmw` is the ROS 2 middleware library. -It is **Quality Level 4**, see its [Quality Declaration document](https://github.com/ros2/rmw/blob/master/rmw/QUALITY_DECLARATION.md). +It is **Quality Level 4**, see its [Quality Declaration document](https://github.com/ros2/rmw/blob/foxy/rmw/QUALITY_DECLARATION.md). #### `rosidl_runtime_c` `rosidl_runtime_c` provides runtime functionality for rosidl message and service interfaces. -It is **Quality Level 4**, see its [Quality Declaration document](https://github.com/ros2/rosidl/blob/master/rosidl_runtime_c/QUALITY_DECLARATION.md). +It is **Quality Level 4**, see its [Quality Declaration document](https://github.com/ros2/rosidl/blob/foxy/rosidl_runtime_c/QUALITY_DECLARATION.md). ### Direct Runtime Non-ROS Dependencies [5.iii] diff --git a/rcl_lifecycle/QUALITY_DECLARATION.md b/rcl_lifecycle/QUALITY_DECLARATION.md index 837996f96..d04f58b67 100644 --- a/rcl_lifecycle/QUALITY_DECLARATION.md +++ b/rcl_lifecycle/QUALITY_DECLARATION.md @@ -138,7 +138,7 @@ It also has several test dependencies, which do not affect the resulting quality `lifecycle_msgs` provides message and services for managing lifecycle nodes. -It is **Quality Level 4**, see its [Quality Declaration document](https://github.com/ros2/rcl_interfaces/blob/master/lifecycle_msgs/QUALITY_DECLARATION.md). +It is **Quality Level 4**, see its [Quality Declaration document](https://github.com/ros2/rcl_interfaces/blob/foxy/lifecycle_msgs/QUALITY_DECLARATION.md). #### `rcl` @@ -150,19 +150,19 @@ It is **Quality Level 3**, see its [Quality Declaration document](../rcl/QUALITY `rcutils` provides commonly used functionality in C. -It is **Quality Level 4**, see its [Quality Declaration document](https://github.com/ros2/rcutils/blob/master/QUALITY_DECLARATION.md). +It is **Quality Level 4**, see its [Quality Declaration document](https://github.com/ros2/rcutils/blob/foxy/QUALITY_DECLARATION.md). #### `rmw` `rmw` is the ROS 2 middleware library. -It is **Quality Level 4**, see its [Quality Declaration document](https://github.com/ros2/rmw/blob/master/rmw/QUALITY_DECLARATION.md). +It is **Quality Level 4**, see its [Quality Declaration document](https://github.com/ros2/rmw/blob/foxy/rmw/QUALITY_DECLARATION.md). #### `rosidl_runtime_c` `rosidl_runtime_c` provides runtime functionality for rosidl message and service interfaces. -It is **Quality Level 4**, see its [Quality Declaration document](https://github.com/ros2/rosidl/blob/master/rosidl_runtime_c/QUALITY_DECLARATION.md). +It is **Quality Level 4**, see its [Quality Declaration document](https://github.com/ros2/rosidl/blob/foxy/rosidl_runtime_c/QUALITY_DECLARATION.md). ### Direct Runtime Non-ROS Dependencies [5.iii] diff --git a/rcl_yaml_param_parser/QUALITY_DECLARATION.md b/rcl_yaml_param_parser/QUALITY_DECLARATION.md index f42929085..9f6ed0bde 100644 --- a/rcl_yaml_param_parser/QUALITY_DECLARATION.md +++ b/rcl_yaml_param_parser/QUALITY_DECLARATION.md @@ -135,13 +135,13 @@ It also has several test dependencies, which do not affect the resulting quality `rcutils` provides commonly used functionality in C. -It is **Quality Level 3**, see its [Quality Declaration document](https://github.com/ros2/rcutils/blob/master/QUALITY_DECLARATION.md). +It is **Quality Level 3**, see its [Quality Declaration document](https://github.com/ros2/rcutils/blob/foxy/QUALITY_DECLARATION.md). #### `libyaml_vendor` `libyaml_vendor` is a vendor package for the libyaml C library. -It is **Quality Level 4**, see its [Quality Declaration document](https://github.com/ros2/libyaml_vendor/blob/master/QUALITY_DECLARATION.md). +It is **Quality Level 4**, see its [Quality Declaration document](https://github.com/ros2/libyaml_vendor/blob/foxy/QUALITY_DECLARATION.md). ### Direct Runtime Non-ROS Dependencies [5.iii] @@ -151,7 +151,7 @@ It is **Quality Level 4**, see its [Quality Declaration document](https://github `libyaml` is a YAML parsing library written in C. -It is **Quality Level 4**, see its [Quality Declaration document](https://github.com/ros2/libyaml_vendor/blob/master/libyaml_q_declaration.md). +It is **Quality Level 4**, see its [Quality Declaration document](https://github.com/ros2/libyaml_vendor/blob/foxy/libyaml_q_declaration.md). ## Platform Support [6] From 2cb858c2d647cbf9ca5b08814794716d1745bc0e Mon Sep 17 00:00:00 2001 From: Christophe Bedard Date: Wed, 28 Oct 2020 14:41:04 -0400 Subject: [PATCH 5/8] Update tracetools QL and add to rcl_lifecycle's QD (#845) List tracetools in rcl_lifecycle's QD Signed-off-by: Christophe Bedard --- rcl/QUALITY_DECLARATION.md | 2 +- rcl_lifecycle/QUALITY_DECLARATION.md | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/rcl/QUALITY_DECLARATION.md b/rcl/QUALITY_DECLARATION.md index ac7f14d77..43f7eb7e1 100644 --- a/rcl/QUALITY_DECLARATION.md +++ b/rcl/QUALITY_DECLARATION.md @@ -187,7 +187,7 @@ It is **Quality Level 4**, see its [Quality Declaration document](https://github The `tracetools` package provides utilities for instrumenting the code in `rcl` so that it may be traced for debugging and performance analysis. -It is **Quality Level 2**, see its [Quality Declaration document](https://gitlab.com/micro-ROS/ros_tracing/ros2_tracing/-/blob/foxy/tracetools/QUALITY_DECLARATION.md). +It is **Quality Level 1**, see its [Quality Declaration document](https://gitlab.com/ros-tracing/ros2_tracing/-/blob/master/tracetools/QUALITY_DECLARATION.md). ### Optional Direct Runtime ROS Dependencies [5.ii] diff --git a/rcl_lifecycle/QUALITY_DECLARATION.md b/rcl_lifecycle/QUALITY_DECLARATION.md index d04f58b67..44d586290 100644 --- a/rcl_lifecycle/QUALITY_DECLARATION.md +++ b/rcl_lifecycle/QUALITY_DECLARATION.md @@ -164,6 +164,12 @@ It is **Quality Level 4**, see its [Quality Declaration document](https://github It is **Quality Level 4**, see its [Quality Declaration document](https://github.com/ros2/rosidl/blob/foxy/rosidl_runtime_c/QUALITY_DECLARATION.md). +#### `tracetools` + +The `tracetools` package provides utilities for instrumenting the code in `rcl_lifecycle` so that it may be traced for debugging and performance analysis. + +It is **Quality Level 1**, see its [Quality Declaration document](https://gitlab.com/ros-tracing/ros2_tracing/-/blob/master/tracetools/QUALITY_DECLARATION.md). + ### Direct Runtime Non-ROS Dependencies [5.iii] `rcl_lifecycle` does not have any runtime non-ROS dependencies. From 533d7bfae28a0500a537d129456dddf99df0cd74 Mon Sep 17 00:00:00 2001 From: ahcorde Date: Thu, 29 Oct 2020 17:56:46 +0100 Subject: [PATCH 6/8] update QL dependencies on rcl_yaml_param_parser Signed-off-by: ahcorde --- rcl_yaml_param_parser/QUALITY_DECLARATION.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/rcl_yaml_param_parser/QUALITY_DECLARATION.md b/rcl_yaml_param_parser/QUALITY_DECLARATION.md index 9f6ed0bde..39e660fbf 100644 --- a/rcl_yaml_param_parser/QUALITY_DECLARATION.md +++ b/rcl_yaml_param_parser/QUALITY_DECLARATION.md @@ -135,13 +135,13 @@ It also has several test dependencies, which do not affect the resulting quality `rcutils` provides commonly used functionality in C. -It is **Quality Level 3**, see its [Quality Declaration document](https://github.com/ros2/rcutils/blob/foxy/QUALITY_DECLARATION.md). +It is **Quality Level 1**, see its [Quality Declaration document](https://github.com/ros2/rcutils/blob/foxy/QUALITY_DECLARATION.md). #### `libyaml_vendor` `libyaml_vendor` is a vendor package for the libyaml C library. -It is **Quality Level 4**, see its [Quality Declaration document](https://github.com/ros2/libyaml_vendor/blob/foxy/QUALITY_DECLARATION.md). +It is **Quality Level 1**, see its [Quality Declaration document](https://github.com/ros2/libyaml_vendor/blob/foxy/QUALITY_DECLARATION.md). ### Direct Runtime Non-ROS Dependencies [5.iii] @@ -151,7 +151,7 @@ It is **Quality Level 4**, see its [Quality Declaration document](https://github `libyaml` is a YAML parsing library written in C. -It is **Quality Level 4**, see its [Quality Declaration document](https://github.com/ros2/libyaml_vendor/blob/foxy/libyaml_q_declaration.md). +It is **Quality Level 1**, see its [Quality Declaration document](https://github.com/ros2/libyaml_vendor/blob/foxy/libyaml_q_declaration.md). ## Platform Support [6] From ed05c9fa96f8911cbc38508ec1c0cf3c4ee6d1d3 Mon Sep 17 00:00:00 2001 From: ahcorde Date: Tue, 3 Nov 2020 09:02:23 +0100 Subject: [PATCH 7/8] Updated QD Signed-off-by: ahcorde --- rcl/QUALITY_DECLARATION.md | 12 ++++++------ rcl/README.md | 2 +- rcl_action/QUALITY_DECLARATION.md | 10 +++++----- rcl_action/README.md | 2 +- rcl_lifecycle/QUALITY_DECLARATION.md | 14 +++++++------- rcl_lifecycle/README.md | 2 +- rcl_yaml_param_parser/QUALITY_DECLARATION.md | 4 ++-- rcl_yaml_param_parser/README.md | 2 +- 8 files changed, 24 insertions(+), 24 deletions(-) diff --git a/rcl/QUALITY_DECLARATION.md b/rcl/QUALITY_DECLARATION.md index 43f7eb7e1..9d63e2d4d 100644 --- a/rcl/QUALITY_DECLARATION.md +++ b/rcl/QUALITY_DECLARATION.md @@ -2,7 +2,7 @@ This document is a declaration of software quality for the `rcl` package, based # `rcl` Quality Declaration -The package `rcl` claims to be in the **Quality Level 3** category. +The package `rcl` claims to be in the **Quality Level 2** category. Below are the rationales, notes, and caveats for this claim, organized by each requirement listed in the [Package Quality Categories in REP-2004](https://index.ros.org/doc/ros2/Contributing/Developer-Guide/#package-quality-categories). @@ -151,7 +151,7 @@ It is **Quality Level 4**, see its [Quality Declaration document](https://github The `rcl_interfaces` package provides some common ROS Message and ROS Service types which are used to implement certain client library features. -It is **Quality Level 4**, see its [Quality Declaration document](https://github.com/ros2/rcl_interfaces/blob/foxy/rcl_interfaces/QUALITY_DECLARATION.md). +It is **Quality Level 2**, see its [Quality Declaration document](https://github.com/ros2/rcl_interfaces/blob/foxy/rcl_interfaces/QUALITY_DECLARATION.md). #### `rcl_logging_spdlog` @@ -163,7 +163,7 @@ It is **Quality Level 4**, see its [Quality Declaration document](https://github The `rcl_yaml_param_parser` package provides an API that is used to parse YAML configuration files which may be used to configure ROS and specific nodes. -It is **Quality Level 4**, see its [Quality Declaration document](https://github.com/ros2/rcl/tree/foxy/rcl_yaml_param_parser/Quality_Declaration.md). +It is **Quality Level 2**, see its [Quality Declaration document](https://github.com/ros2/rcl/tree/foxy/rcl_yaml_param_parser/Quality_Declaration.md). #### `rcutils` @@ -175,19 +175,19 @@ It is **Quality Level 2**, see its [Quality Declaration document](https://github The `rmw_implementation` package provides access to the default rmw implementation, and provides the ability to dynamically switch rmw implementations if more than one is available. -It is **Quality Level 4**, see its [Quality Declaration document](https://github.com/ros2/rmw_implementation/blob/foxy/QUALITY_DECLARATION.md). +It is **Quality Level 2**, see its [Quality Declaration document](https://github.com/ros2/rmw_implementation/blob/foxy/QUALITY_DECLARATION.md). #### `rosidl_runtime_c` The `rosidl_runtime_c` package provides runtime interfaces in C based on user defined ROS Messages and ROS Services, as well as associated support functions for those types. -It is **Quality Level 4**, see its [Quality Declaration document](https://github.com/ros2/rosidl/tree/foxy/rosidl_runtime_c/Quality_Declaration.md). +It is **Quality Level 1**, see its [Quality Declaration document](https://github.com/ros2/rosidl/tree/foxy/rosidl_runtime_c/Quality_Declaration.md). #### `tracetools` The `tracetools` package provides utilities for instrumenting the code in `rcl` so that it may be traced for debugging and performance analysis. -It is **Quality Level 1**, see its [Quality Declaration document](https://gitlab.com/ros-tracing/ros2_tracing/-/blob/master/tracetools/QUALITY_DECLARATION.md). +It is **Quality Level 1**, see its [Quality Declaration document](https://gitlab.com/ros-tracing/ros2_tracing/-/blob/foxy/tracetools/QUALITY_DECLARATION.md). ### Optional Direct Runtime ROS Dependencies [5.ii] diff --git a/rcl/README.md b/rcl/README.md index c602d8044..51cf9c100 100644 --- a/rcl/README.md +++ b/rcl/README.md @@ -4,4 +4,4 @@ Library to support implementation of language specific ROS Client Libraries. Features are described in detail at [http://docs.ros2.org](http://docs.ros2.org/latest/api/rcl/index.html) -This package claims to be in the **Quality Level 3** category, see the [Quality Declaration](./QUALITY_DECLARATION.md) for more details. +This package claims to be in the **Quality Level 2** category, see the [Quality Declaration](./QUALITY_DECLARATION.md) for more details. diff --git a/rcl_action/QUALITY_DECLARATION.md b/rcl_action/QUALITY_DECLARATION.md index 69e995a87..6416efe84 100644 --- a/rcl_action/QUALITY_DECLARATION.md +++ b/rcl_action/QUALITY_DECLARATION.md @@ -2,7 +2,7 @@ This document is a declaration of software quality for the `rcl_action` package, # `rcl_action` Quality Declaration -The package `rcl_action` claims to be in the **Quality Level 3** category. +The package `rcl_action` claims to be in the **Quality Level 2** category. Below are the rationales, notes, and caveats for this claim, organized by each requirement listed in the [Package Quality Categories in REP-2004](https://index.ros.org/doc/ros2/Contributing/Developer-Guide/#package-quality-categories). @@ -137,13 +137,13 @@ It also has several test dependencies, which do not affect the resulting quality `action_msgs` provides messages and services for ROS 2 actions. -It is **Quality Level 4**, see its [Quality Declaration document](https://github.com/ros2/rcl_interfaces/blob/foxy/action_msgs/QUALITY_DECLARATION.md). +It is **Quality Level 2**, see its [Quality Declaration document](https://github.com/ros2/rcl_interfaces/blob/foxy/action_msgs/QUALITY_DECLARATION.md). #### `rcl` `rcl` is the ROS 2 client library in C. -It is **Quality Level 3**, see its [Quality Declaration document](../rcl/QUALITY_DECLARATION). +It is **Quality Level 2**, see its [Quality Declaration document](../rcl/QUALITY_DECLARATION). #### `rcutils` @@ -155,13 +155,13 @@ It is **Quality Level 2**, see its [Quality Declaration document](https://github `rmw` is the ROS 2 middleware library. -It is **Quality Level 4**, see its [Quality Declaration document](https://github.com/ros2/rmw/blob/foxy/rmw/QUALITY_DECLARATION.md). +It is **Quality Level 2**, see its [Quality Declaration document](https://github.com/ros2/rmw/blob/foxy/rmw/QUALITY_DECLARATION.md). #### `rosidl_runtime_c` `rosidl_runtime_c` provides runtime functionality for rosidl message and service interfaces. -It is **Quality Level 4**, see its [Quality Declaration document](https://github.com/ros2/rosidl/blob/foxy/rosidl_runtime_c/QUALITY_DECLARATION.md). +It is **Quality Level 1**, see its [Quality Declaration document](https://github.com/ros2/rosidl/blob/foxy/rosidl_runtime_c/QUALITY_DECLARATION.md). ### Direct Runtime Non-ROS Dependencies [5.iii] diff --git a/rcl_action/README.md b/rcl_action/README.md index 2f74f5b08..73843dd40 100644 --- a/rcl_action/README.md +++ b/rcl_action/README.md @@ -9,4 +9,4 @@ http://design.ros2.org/articles/actions.html ## Quality Declaration -This package claims to be in the **Quality Level 3** category, see the [Quality Declaration](./QUALITY_DECLARATION.md) for more details. +This package claims to be in the **Quality Level 2** category, see the [Quality Declaration](./QUALITY_DECLARATION.md) for more details. diff --git a/rcl_lifecycle/QUALITY_DECLARATION.md b/rcl_lifecycle/QUALITY_DECLARATION.md index 44d586290..c9f6bc607 100644 --- a/rcl_lifecycle/QUALITY_DECLARATION.md +++ b/rcl_lifecycle/QUALITY_DECLARATION.md @@ -2,7 +2,7 @@ This document is a declaration of software quality for the `rcl_lifecycle` packa # `rcl_lifecycle` Quality Declaration -The package `rcl_lifecycle` claims to be in the **Quality Level 3** category. +The package `rcl_lifecycle` claims to be in the **Quality Level 2** category. Below are the rationales, notes, and caveats for this claim, organized by each requirement listed in the [Package Quality Categories in REP-2004](https://index.ros.org/doc/ros2/Contributing/Developer-Guide/#package-quality-categories). @@ -138,37 +138,37 @@ It also has several test dependencies, which do not affect the resulting quality `lifecycle_msgs` provides message and services for managing lifecycle nodes. -It is **Quality Level 4**, see its [Quality Declaration document](https://github.com/ros2/rcl_interfaces/blob/foxy/lifecycle_msgs/QUALITY_DECLARATION.md). +It is **Quality Level 2**, see its [Quality Declaration document](https://github.com/ros2/rcl_interfaces/blob/foxy/lifecycle_msgs/QUALITY_DECLARATION.md). #### `rcl` `rcl` is the ROS 2 client library in C. -It is **Quality Level 3**, see its [Quality Declaration document](../rcl/QUALITY_DECLARATION). +It is **Quality Level 2**, see its [Quality Declaration document](../rcl/QUALITY_DECLARATION). #### `rcutils` `rcutils` provides commonly used functionality in C. -It is **Quality Level 4**, see its [Quality Declaration document](https://github.com/ros2/rcutils/blob/foxy/QUALITY_DECLARATION.md). +It is **Quality Level 2**, see its [Quality Declaration document](https://github.com/ros2/rcutils/blob/foxy/QUALITY_DECLARATION.md). #### `rmw` `rmw` is the ROS 2 middleware library. -It is **Quality Level 4**, see its [Quality Declaration document](https://github.com/ros2/rmw/blob/foxy/rmw/QUALITY_DECLARATION.md). +It is **Quality Level 2**, see its [Quality Declaration document](https://github.com/ros2/rmw/blob/foxy/rmw/QUALITY_DECLARATION.md). #### `rosidl_runtime_c` `rosidl_runtime_c` provides runtime functionality for rosidl message and service interfaces. -It is **Quality Level 4**, see its [Quality Declaration document](https://github.com/ros2/rosidl/blob/foxy/rosidl_runtime_c/QUALITY_DECLARATION.md). +It is **Quality Level 1**, see its [Quality Declaration document](https://github.com/ros2/rosidl/blob/foxy/rosidl_runtime_c/QUALITY_DECLARATION.md). #### `tracetools` The `tracetools` package provides utilities for instrumenting the code in `rcl_lifecycle` so that it may be traced for debugging and performance analysis. -It is **Quality Level 1**, see its [Quality Declaration document](https://gitlab.com/ros-tracing/ros2_tracing/-/blob/master/tracetools/QUALITY_DECLARATION.md). +It is **Quality Level 1**, see its [Quality Declaration document](https://gitlab.com/ros-tracing/ros2_tracing/-/blob/foxy/tracetools/QUALITY_DECLARATION.md). ### Direct Runtime Non-ROS Dependencies [5.iii] diff --git a/rcl_lifecycle/README.md b/rcl_lifecycle/README.md index a161d0806..77aa9e823 100644 --- a/rcl_lifecycle/README.md +++ b/rcl_lifecycle/README.md @@ -9,4 +9,4 @@ https://design.ros2.org/articles/node_lifecycle.html ## Quality Declaration -This package claims to be in the **Quality Level 3** category, see the [Quality Declaration](./QUALITY_DECLARATION.md) for more details. +This package claims to be in the **Quality Level 2** category, see the [Quality Declaration](./QUALITY_DECLARATION.md) for more details. diff --git a/rcl_yaml_param_parser/QUALITY_DECLARATION.md b/rcl_yaml_param_parser/QUALITY_DECLARATION.md index 39e660fbf..6f61726d7 100644 --- a/rcl_yaml_param_parser/QUALITY_DECLARATION.md +++ b/rcl_yaml_param_parser/QUALITY_DECLARATION.md @@ -2,7 +2,7 @@ This document is a declaration of software quality for the `rcl_yaml_param_parse # `rcl_yaml_param_parser` Quality Declaration -The package `rcl_yaml_param_parser` claims to be in the **Quality Level 3** category. +The package `rcl_yaml_param_parser` claims to be in the **Quality Level 2** category. Below are the rationales, notes, and caveats for this claim, organized by each requirement listed in the [Package Quality Categories in REP-2004](https://index.ros.org/doc/ros2/Contributing/Developer-Guide/#package-quality-categories). @@ -135,7 +135,7 @@ It also has several test dependencies, which do not affect the resulting quality `rcutils` provides commonly used functionality in C. -It is **Quality Level 1**, see its [Quality Declaration document](https://github.com/ros2/rcutils/blob/foxy/QUALITY_DECLARATION.md). +It is **Quality Level 2**, see its [Quality Declaration document](https://github.com/ros2/rcutils/blob/foxy/QUALITY_DECLARATION.md). #### `libyaml_vendor` diff --git a/rcl_yaml_param_parser/README.md b/rcl_yaml_param_parser/README.md index e402a1eb6..7d0c161e3 100644 --- a/rcl_yaml_param_parser/README.md +++ b/rcl_yaml_param_parser/README.md @@ -30,4 +30,4 @@ This package depends on C libyaml. ## Quality Declaration -This package claims to be in the **Quality Level 3** category, see the [Quality Declaration](./QUALITY_DECLARATION.md) for more details. +This package claims to be in the **Quality Level 2** category, see the [Quality Declaration](./QUALITY_DECLARATION.md) for more details. From 40621194239345dd662479f7cb1a05ab905c1915 Mon Sep 17 00:00:00 2001 From: ahcorde Date: Wed, 4 Nov 2020 08:11:11 +0100 Subject: [PATCH 8/8] Updated QD Signed-off-by: ahcorde --- rcl/QUALITY_DECLARATION.md | 4 ++-- rcl_lifecycle/QUALITY_DECLARATION.md | 6 ------ 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/rcl/QUALITY_DECLARATION.md b/rcl/QUALITY_DECLARATION.md index 9d63e2d4d..96ae378a6 100644 --- a/rcl/QUALITY_DECLARATION.md +++ b/rcl/QUALITY_DECLARATION.md @@ -175,13 +175,13 @@ It is **Quality Level 2**, see its [Quality Declaration document](https://github The `rmw_implementation` package provides access to the default rmw implementation, and provides the ability to dynamically switch rmw implementations if more than one is available. -It is **Quality Level 2**, see its [Quality Declaration document](https://github.com/ros2/rmw_implementation/blob/foxy/QUALITY_DECLARATION.md). +It is **Quality Level 2**, see its [Quality Declaration document](https://github.com/ros2/rmw_implementation/blob/foxy/rmw_implementation/QUALITY_DECLARATION.md). #### `rosidl_runtime_c` The `rosidl_runtime_c` package provides runtime interfaces in C based on user defined ROS Messages and ROS Services, as well as associated support functions for those types. -It is **Quality Level 1**, see its [Quality Declaration document](https://github.com/ros2/rosidl/tree/foxy/rosidl_runtime_c/Quality_Declaration.md). +It is **Quality Level 1**, see its [Quality Declaration document](https://github.com/ros2/rosidl/blob/foxy/rosidl_runtime_c/QUALITY_DECLARATION.md). #### `tracetools` diff --git a/rcl_lifecycle/QUALITY_DECLARATION.md b/rcl_lifecycle/QUALITY_DECLARATION.md index c9f6bc607..cee4ac427 100644 --- a/rcl_lifecycle/QUALITY_DECLARATION.md +++ b/rcl_lifecycle/QUALITY_DECLARATION.md @@ -164,12 +164,6 @@ It is **Quality Level 2**, see its [Quality Declaration document](https://github It is **Quality Level 1**, see its [Quality Declaration document](https://github.com/ros2/rosidl/blob/foxy/rosidl_runtime_c/QUALITY_DECLARATION.md). -#### `tracetools` - -The `tracetools` package provides utilities for instrumenting the code in `rcl_lifecycle` so that it may be traced for debugging and performance analysis. - -It is **Quality Level 1**, see its [Quality Declaration document](https://gitlab.com/ros-tracing/ros2_tracing/-/blob/foxy/tracetools/QUALITY_DECLARATION.md). - ### Direct Runtime Non-ROS Dependencies [5.iii] `rcl_lifecycle` does not have any runtime non-ROS dependencies.