From 08fabf2c9c79a3a90a281fe59b59a74e81ed2081 Mon Sep 17 00:00:00 2001 From: James Xu Date: Thu, 17 Jan 2019 16:59:04 -0800 Subject: [PATCH 1/4] ignore dll import and export errors on msvc (#11) --- include/class_loader/visibility_control.hpp | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/include/class_loader/visibility_control.hpp b/include/class_loader/visibility_control.hpp index ee3224fc..ae9079d5 100644 --- a/include/class_loader/visibility_control.hpp +++ b/include/class_loader/visibility_control.hpp @@ -61,4 +61,11 @@ #define CLASS_LOADER_PUBLIC_TYPE #endif +// based on wiki.ros.org: http://wiki.ros.org/win_ros/Contributing/Dll%20Exports +// Ignore warnings about import/exports when deriving from std classes. +#ifdef _MSC_VER + #pragma warning(disable: 4251) + #pragma warning(disable: 4275) +#endif + #endif // CLASS_LOADER__VISIBILITY_CONTROL_HPP_ From 2b37f643c6e7980da0583c26814704028464c078 Mon Sep 17 00:00:00 2001 From: James Xu Date: Thu, 31 Jan 2019 09:08:52 -0800 Subject: [PATCH 2/4] add documentation links to compiler warnings --- include/class_loader/visibility_control.hpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/class_loader/visibility_control.hpp b/include/class_loader/visibility_control.hpp index ae9079d5..1cf78819 100644 --- a/include/class_loader/visibility_control.hpp +++ b/include/class_loader/visibility_control.hpp @@ -64,7 +64,9 @@ // based on wiki.ros.org: http://wiki.ros.org/win_ros/Contributing/Dll%20Exports // Ignore warnings about import/exports when deriving from std classes. #ifdef _MSC_VER + // https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4251?view=vs-2017 #pragma warning(disable: 4251) + // https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-2-c4275?view=vs-2017 #pragma warning(disable: 4275) #endif From 7bb6ac1d3d0e327d45ceba8cb9d91e2faef87d09 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Steven!=20Ragnar=C3=B6k?= Date: Thu, 31 Jan 2019 09:59:00 -0800 Subject: [PATCH 3/4] Update include/class_loader/visibility_control.hpp Co-Authored-By: kejxu --- include/class_loader/visibility_control.hpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/class_loader/visibility_control.hpp b/include/class_loader/visibility_control.hpp index 1cf78819..c52c2565 100644 --- a/include/class_loader/visibility_control.hpp +++ b/include/class_loader/visibility_control.hpp @@ -63,6 +63,8 @@ // based on wiki.ros.org: http://wiki.ros.org/win_ros/Contributing/Dll%20Exports // Ignore warnings about import/exports when deriving from std classes. +// https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4251 +// https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-2-c4275 #ifdef _MSC_VER // https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4251?view=vs-2017 #pragma warning(disable: 4251) From d40a128f12bbe701c41478c20eeb2787c683fd8d Mon Sep 17 00:00:00 2001 From: James Xu Date: Thu, 31 Jan 2019 09:59:43 -0800 Subject: [PATCH 4/4] remove duplicate links --- include/class_loader/visibility_control.hpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/class_loader/visibility_control.hpp b/include/class_loader/visibility_control.hpp index c52c2565..270fa2a4 100644 --- a/include/class_loader/visibility_control.hpp +++ b/include/class_loader/visibility_control.hpp @@ -66,9 +66,7 @@ // https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4251 // https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-2-c4275 #ifdef _MSC_VER - // https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4251?view=vs-2017 #pragma warning(disable: 4251) - // https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-2-c4275?view=vs-2017 #pragma warning(disable: 4275) #endif