Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring melodic-devel closer to ros2 branch #76

Merged
merged 13 commits into from
Feb 8, 2018

Conversation

mikaelarguedas
Copy link
Member

@mikaelarguedas mikaelarguedas commented Feb 7, 2018

This PR does a few things:

  • comply with ROS2 linters (ABI breaking changes):
  • comply with -Wpedantic and -Wextra compiler flags:
  • use size_t everytime we're using a size returned by a vector
  • drop compatibility mode for console_bridge < 0.3.0
  • simplify branching logic in a few places

What I didnt pull from the ROS2 branch:

What will be done in a follow-up (hopefully before releasing into melodic):

  • fix constness of functions and arguments
  • infer full library name based on system (prefix with lib where necessary and append proper extension)

Nices to have:

  • provide STL version of all functions as alternative to boost
  • PIMPL
  • Visibility macros for windows
  • backport fviz test from ros2 branch

@mikaelarguedas mikaelarguedas changed the title Stricter compiler options Bring closer to ros2 branch Feb 8, 2018
@mikaelarguedas mikaelarguedas changed the title Bring closer to ros2 branch Bring melodic-devel closer to ros2 branch Feb 8, 2018
@@ -1,5 +1,13 @@
cmake_minimum_required(VERSION 2.8.3)
project(class_loader)
cmake_minimum_required(VERSION 3.5)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.1.3 would actually be enough but I went for 3.5 as this matches ROS 2 current minimum requirement and is way below any platform targeted by melodic


# Default to C++14
if(NOT CMAKE_CXX_STANDARD)
set(CMAKE_CXX_STANDARD 14)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be the default on all platforms targeted by melodic but may be needed for OSX support

@mikaelarguedas mikaelarguedas merged commit c2bbc09 into melodic-devel Feb 8, 2018
@mikaelarguedas mikaelarguedas deleted the stricter_compiler_options branch February 8, 2018 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant