-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring melodic-devel closer to ros2 branch #76
Conversation
cc894bf
to
71a3d3e
Compare
@@ -1,5 +1,13 @@ | |||
cmake_minimum_required(VERSION 2.8.3) | |||
project(class_loader) | |||
cmake_minimum_required(VERSION 3.5) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3.1.3 would actually be enough but I went for 3.5 as this matches ROS 2 current minimum requirement and is way below any platform targeted by melodic
|
||
# Default to C++14 | ||
if(NOT CMAKE_CXX_STANDARD) | ||
set(CMAKE_CXX_STANDARD 14) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be the default on all platforms targeted by melodic but may be needed for OSX support
This PR does a few things:
What I didnt pull from the ROS2 branch:
What will be done in a follow-up (hopefully before releasing into melodic):
lib
where necessary and append proper extension)Nices to have: