Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/testscript: do not create an extra temporary directory #259

Merged
merged 1 commit into from
Jun 11, 2024

Commits on Jun 11, 2024

  1. cmd/testscript: do not create an extra temporary directory

    It's bugged me for a long time that the error messages printed
    by the `testscript` command do not refer to the actual files
    passed to the command, but instead to a temporary
    file created for the purposes of the command.
    
    This change alters the testscript command so that it
    avoids creating an extra copy of the script file, instead
    using the new ability of the testscript package to interpret
    explicitly provided files instead.
    
    Gratifyingly, this also simplifies the logic quite a bit.
    
    Note: this is dependent on #258, so should not be reviewed
    until that lands.
    rogpeppe committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    77ab7d1 View commit details
    Browse the repository at this point in the history