Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testscript: remove errgo dependency #155

Merged
merged 1 commit into from
Mar 9, 2022
Merged

testscript: remove errgo dependency #155

merged 1 commit into from
Mar 9, 2022

Conversation

rogpeppe
Copy link
Owner

@rogpeppe rogpeppe commented Mar 9, 2022

There's no need to use it and every dependency lost is good.

There's no need to use it and every dependency lost is good.
@rogpeppe rogpeppe requested a review from mvdan March 9, 2022 09:18
@rogpeppe rogpeppe merged commit b66946f into master Mar 9, 2022
@thepudds
Copy link
Contributor

thepudds commented Mar 9, 2022

This is great - thanks!

FWIW, there are a couple places I would like to use go-internal but I’m not due to people’s sensitivities around dependencies (coupled with the broader issue of it’s not easy or broadly known how to differentiate test-only dependencies…)

@thepudds
Copy link
Contributor

thepudds commented Mar 9, 2022

That’s also partly what caused me to investigate pkg/diff#26 (comment) (along with a nerd-sniping tweet from @myitcv)…

… but I am progressively getting more off-topic – mainly just wanted to say thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants