From 2eab40bb862b9e75b76a38971ede327cab131e6f Mon Sep 17 00:00:00 2001 From: moloko Date: Wed, 17 Jun 2020 17:39:39 +0100 Subject: [PATCH] onItemsActiveChange: remove underscore from parameter and return early (makes it consistent with onItemsVisitedChange) --- js/narrativeView.js | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/js/narrativeView.js b/js/narrativeView.js index 30b9268..da2f0df 100644 --- a/js/narrativeView.js +++ b/js/narrativeView.js @@ -36,10 +36,9 @@ define([ this.calculateWidths(); } - onItemsActiveChange(item, _isActive) { - if (_isActive === true) { - this.setStage(item); - } + onItemsActiveChange(item, isActive) { + if (!isActive) return; + this.setStage(item); } onItemsVisitedChange(item, isVisited) {