diff --git a/ReactAndroid/src/main/java/com/facebook/react/uimanager/ReactShadowNodeImpl.java b/ReactAndroid/src/main/java/com/facebook/react/uimanager/ReactShadowNodeImpl.java index cefa9ab7f02f5c..cec4356528eab3 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/uimanager/ReactShadowNodeImpl.java +++ b/ReactAndroid/src/main/java/com/facebook/react/uimanager/ReactShadowNodeImpl.java @@ -180,6 +180,14 @@ public void dirty() { } else if (getParent() != null) { // Virtual nodes aren't involved in layout but they need to have the dirty signal // propagated to their ancestors. + // + // TODO: There are some edge cases that currently aren't supported. For example, if the size + // of your inline image/view changes, its size on-screen is not be updated. Similarly, + // if the size of a view inside of an inline view changes, its size on-screen is not + // updated. The problem may be that dirty propagation stops at inline views because the + // parent of each inline view is null. A possible fix would be to implement an `onDirty` + // handler in Yoga that will propagate the dirty signal to the ancestors of the inline view. + // getParent().dirty(); } }