Enable Default Support for Protobuf #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm afraid why you call it Default for Protobuf? When it seems you just disabled auto-creating for Avro. |
|
@sashati by disabling default avro codec creation, we stop default client from trying to create protobuf avro codecs. |
|
Thanks @AtakanColak for the reply. I get the point. |
riferrei
approved these changes
Nov 13, 2020
thinker0
added a commit
to thinker0/srclient
that referenced
this pull request
May 11, 2021
* commit '975a69734c7052463bf133ad7ac4a92dc5dfc3ea': Add the ability to create a schema with an arbitrary name (riferrei#43) Add .gitignore (riferrei#40) Add delete subject (riferrei#38) Enable Default Support for Protobuf fix-30 (riferrei#36) add IsCompatible add mutex to codec and caching enabled add semaphore to http requests # Conflicts: # go.mod # schemaRegistryClient.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By setting default codecCreation to false we can have default support for protobuf. Also added Codec generation to schema.Codec() call to make up for this change, this way overall behaviour will stay the same for avro users. Fixes #30