Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Response handling problems #48

Closed
DerekHoyle opened this issue Jan 14, 2020 · 0 comments
Closed

Response handling problems #48

DerekHoyle opened this issue Jan 14, 2020 · 0 comments

Comments

@DerekHoyle
Copy link
Collaborator

In Uds.py:

If a request is sent with suppressRespose=True, the response is still tested for "response pending" (0x78), even though response is None. See code starting at line 140.

The response pending would only work for a single response pending too. There could be several.

Perhaps replace with this:

    if responseRequired:
          while True:
              response = self.tp.recv(self.__P2_CAN_Client)
              if not ((response[0] == 0x7F) and (response[2] == 0x78)):
                  break
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant