Skip to content

Merge pull request #58 from reviewdog/depup/reviewdog/reviewdog #105

Merge pull request #58 from reviewdog/depup/reviewdog/reviewdog

Merge pull request #58 from reviewdog/depup/reviewdog/reviewdog #105

GitHub Actions / shellcheck completed Jun 17, 2024 in 0s

reviewdog [shellcheck] report

reported by reviewdog 🐶

Findings (6)

testdata/test.sh|1 col 1| Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive.
testdata/test.sh|1 col 14| Quote the parameter to -name so the shell won't interpret it.
testdata/test.sh|1 col 14| Use ./glob or -- glob so names with dashes won't become options.
testdata/test.sh|3 col 6| Grep uses regex, but this looks like a glob.
testdata/test.sh|5 col 5| Remove spaces around = to assign (or use [ ] to compare, or quote '=' if literal).
testdata/test.sh|7 col 19| Use $(...) notation instead of legacy backticks ....

Filtered Findings (0)

Annotations

Check failure on line 1 in testdata/test.sh

See this annotation in the file changed.

@github-actions github-actions / shellcheck

[shellcheck] testdata/test.sh#L1 <ShellCheck.SC2148>

Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive.
Raw output
./testdata/test.sh:1:1: error: Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive. (ShellCheck.SC2148)

Check warning on line 1 in testdata/test.sh

See this annotation in the file changed.

@github-actions github-actions / shellcheck

[shellcheck] testdata/test.sh#L1 <ShellCheck.SC2061>

Quote the parameter to -name so the shell won't interpret it.
Raw output
./testdata/test.sh:1:14: warning: Quote the parameter to -name so the shell won't interpret it. (ShellCheck.SC2061)

Check notice on line 1 in testdata/test.sh

See this annotation in the file changed.

@github-actions github-actions / shellcheck

[shellcheck] testdata/test.sh#L1 <ShellCheck.SC2035>

Use ./*glob* or -- *glob* so names with dashes won't become options.
Raw output
./testdata/test.sh:1:14: info: Use ./*glob* or -- *glob* so names with dashes won't become options. (ShellCheck.SC2035)

Check warning on line 3 in testdata/test.sh

See this annotation in the file changed.

@github-actions github-actions / shellcheck

[shellcheck] testdata/test.sh#L3 <ShellCheck.SC2063>

Grep uses regex, but this looks like a glob.
Raw output
./testdata/test.sh:3:6: warning: Grep uses regex, but this looks like a glob. (ShellCheck.SC2063)

Check failure on line 5 in testdata/test.sh

See this annotation in the file changed.

@github-actions github-actions / shellcheck

[shellcheck] testdata/test.sh#L5 <ShellCheck.SC2283>

Remove spaces around = to assign (or use [ ] to compare, or quote '=' if literal).
Raw output
./testdata/test.sh:5:5: error: Remove spaces around = to assign (or use [ ] to compare, or quote '=' if literal). (ShellCheck.SC2283)

Check notice on line 7 in testdata/test.sh

See this annotation in the file changed.

@github-actions github-actions / shellcheck

[shellcheck] testdata/test.sh#L7 <ShellCheck.SC2006>

Use $(...) notation instead of legacy backticks `...`.
Raw output
./testdata/test.sh:7:19: info: Use $(...) notation instead of legacy backticks `...`. (ShellCheck.SC2006)