From a7bf17deef495714c39d6539e0383e0218094888 Mon Sep 17 00:00:00 2001
From: Antoine Beyeler <antoine@rerun.io>
Date: Thu, 12 Oct 2023 16:52:23 +0200
Subject: [PATCH] Fix rebase + clean code

---
 crates/re_data_store/src/store_db.rs          | 20 +++++++++----------
 .../data/quick_start_guides/cpp_native.md     |  2 +-
 .../quick_start_guides/how_does_it_work.md    |  2 +-
 .../data/quick_start_guides/python_native.md  |  2 +-
 .../data/quick_start_guides/rust_native.md    |  2 +-
 .../src/ui/welcome_screen/welcome_page.rs     |  2 +-
 6 files changed, 14 insertions(+), 16 deletions(-)

diff --git a/crates/re_data_store/src/store_db.rs b/crates/re_data_store/src/store_db.rs
index 8d0afdb309b7..128caa4e4818 100644
--- a/crates/re_data_store/src/store_db.rs
+++ b/crates/re_data_store/src/store_db.rs
@@ -245,17 +245,15 @@ impl StoreDb {
         store_info: StoreInfo,
         rows: impl IntoIterator<Item = DataRow>,
     ) -> anyhow::Result<Self> {
-        let arrow_msg = DataTable::from_rows(TableId::random(), rows).to_arrow_msg()?;
-        let store_id = store_info.store_id.clone();
-        let mut store_db = StoreDb::new(store_id.clone());
-        store_db.add(
-            &SetStoreInfo {
-                row_id: RowId::random(),
-                info: store_info,
-            }
-            .into(),
-        )?;
-        store_db.add(&LogMsg::ArrowMsg(store_id, arrow_msg))?;
+        let mut store_db = StoreDb::new(store_info.store_id.clone());
+
+        store_db.set_store_info(SetStoreInfo {
+            row_id: RowId::random(),
+            info: store_info,
+        });
+        for row in rows {
+            store_db.add_data_row(&row)?;
+        }
 
         Ok(store_db)
     }
diff --git a/crates/re_viewer/data/quick_start_guides/cpp_native.md b/crates/re_viewer/data/quick_start_guides/cpp_native.md
index 60714b19e548..5c1b1a84e183 100644
--- a/crates/re_viewer/data/quick_start_guides/cpp_native.md
+++ b/crates/re_viewer/data/quick_start_guides/cpp_native.md
@@ -1,3 +1,3 @@
 ## C++ Quick Start
 
-TODO(ab)
\ No newline at end of file
+TODO(ab)
diff --git a/crates/re_viewer/data/quick_start_guides/how_does_it_work.md b/crates/re_viewer/data/quick_start_guides/how_does_it_work.md
index fd28ee6a7f0f..54171efc8919 100644
--- a/crates/re_viewer/data/quick_start_guides/how_does_it_work.md
+++ b/crates/re_viewer/data/quick_start_guides/how_does_it_work.md
@@ -1,3 +1,3 @@
 ### How does it work?
 
-TBC
\ No newline at end of file
+TBC
diff --git a/crates/re_viewer/data/quick_start_guides/python_native.md b/crates/re_viewer/data/quick_start_guides/python_native.md
index c0f7e844b871..f3933859f1ed 100644
--- a/crates/re_viewer/data/quick_start_guides/python_native.md
+++ b/crates/re_viewer/data/quick_start_guides/python_native.md
@@ -56,4 +56,4 @@ rr.log(
     # log data as a 3D point cloud archetype
     rr.Points3D(positions, colors=colors, radii=0.5)
 )
-```
\ No newline at end of file
+```
diff --git a/crates/re_viewer/data/quick_start_guides/rust_native.md b/crates/re_viewer/data/quick_start_guides/rust_native.md
index 615db72247c0..dc8a66f1634f 100644
--- a/crates/re_viewer/data/quick_start_guides/rust_native.md
+++ b/crates/re_viewer/data/quick_start_guides/rust_native.md
@@ -1,3 +1,3 @@
 ## Rust Quick Start
 
-TODO(ab)
\ No newline at end of file
+TODO(ab)
diff --git a/crates/re_viewer/src/ui/welcome_screen/welcome_page.rs b/crates/re_viewer/src/ui/welcome_screen/welcome_page.rs
index aea4c0014feb..375740e82ed1 100644
--- a/crates/re_viewer/src/ui/welcome_screen/welcome_page.rs
+++ b/crates/re_viewer/src/ui/welcome_screen/welcome_page.rs
@@ -271,7 +271,7 @@ fn open_quick_start<'a>(
     entity_path: impl AsRef<str>,
 ) {
     let markdown = parts.into_iter().join("\n");
-    let res = open_markdown_recording(command_sender, &markdown, app_id, entity_path);
+    let res = open_markdown_recording(command_sender, markdown, app_id, entity_path);
     if let Err(err) = res {
         re_log::error!("Failed to load quick start: {}", err);
     }