diff --git a/.changeset/tame-dots-wash.md b/.changeset/tame-dots-wash.md new file mode 100644 index 00000000000..53d0c2ed873 --- /dev/null +++ b/.changeset/tame-dots-wash.md @@ -0,0 +1,5 @@ +--- +"@remix-run/server-runtime": patch +--- + +fix: change `serializeError` to sync function diff --git a/contributors.yml b/contributors.yml index fe99dfc30d3..df0864cf060 100644 --- a/contributors.yml +++ b/contributors.yml @@ -489,6 +489,7 @@ - XiNiHa - xstevenyung - xdivby0 +- xuchaobei - yauri-io - yesmeck - yomeshgupta diff --git a/packages/remix-server-runtime/errors.ts b/packages/remix-server-runtime/errors.ts index 85f98407f8c..09549bf2c17 100644 --- a/packages/remix-server-runtime/errors.ts +++ b/packages/remix-server-runtime/errors.ts @@ -57,7 +57,7 @@ export type SerializedError = { stack?: string; }; -export async function serializeError(error: Error): Promise { +export function serializeError(error: Error): SerializedError { return { message: error.message, stack: error.stack, diff --git a/packages/remix-server-runtime/server.ts b/packages/remix-server-runtime/server.ts index 0c6503a3588..d04ea5b6b0e 100644 --- a/packages/remix-server-runtime/server.ts +++ b/packages/remix-server-runtime/server.ts @@ -373,8 +373,8 @@ async function handleResourceRequestRR( } } -async function errorBoundaryError(error: Error, status: number) { - return json(await serializeError(error), { +function errorBoundaryError(error: Error, status: number) { + return json(serializeError(error), { status, headers: { "X-Remix-Error": "yes",