Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

static rendering adds a leading slash to all Links #4516

Closed
threepointone opened this issue Feb 11, 2017 · 2 comments
Closed

static rendering adds a leading slash to all Links #4516

threepointone opened this issue Feb 11, 2017 · 2 comments

Comments

@threepointone
Copy link

Version

4.0.0-beta.5

Test Case

renderToStaticMarkup(<StaticRouter location='/' context={{}}>
  <Link to='/a'>to a</Link>
</StaticRouter>)

Steps to reproduce

render a react component containing <Link/>s

Expected Behavior

the string should be <a href="/a">to a</a>

Actual Behavior

the string is <a href="//a">to a</a> (note the extra slash)

(the problem exists with renderToString as well, used the above for brevity)
@pshrmn
Copy link
Contributor

pshrmn commented Feb 11, 2017

Fixed in #4484

@pshrmn pshrmn closed this as completed Feb 11, 2017
@threepointone
Copy link
Author

thanks much!

@lock lock bot locked as resolved and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@threepointone @pshrmn