Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: v7_partialHydration with unstable_patchRoutesOnMiss: hydrateFallbackElement not shown on patched routes #11812

Closed
Manizuca opened this issue Jul 17, 2024 · 5 comments · Fixed by #11838
Labels

Comments

@Manizuca
Copy link

What version of React Router are you using?

6.25.0

Steps to Reproduce

https://stackblitz.com/edit/github-smnznp?file=package.json,src%2Fapp.tsx

  • Have a route that gets patched with unstable_patchRoutesOnMiss
  • Enable v7_partialHydration and add hydrateFallbackElement to the root route
  • Add some delay to the root loader function

Expected Behavior

The fallback element of the root route is shown while the loaders are executing

Actual Behavior

No fallback is shown

  • In the example, load the application at /without-loading-indicator
  • For routes defined from the start, it is shown correctly, like /with-loading-indicator
@Manizuca Manizuca added the bug label Jul 17, 2024
@brophdawg11
Copy link
Contributor

I am not seeing the described behavior. When I load /without-loading-indicator in your stackblitz I see the loading indicator:

Screenshot 2024-07-17 at 1 41 34 PM

@Manizuca
Copy link
Author

Hi @brophdawg11
There is apparently a difference between different browsers, when there is a promise that gets immediately resolved. In Firefox i dont get the message, but in chrome i do

I've updated the demo, so the children promise resolves after 10ms instead of 0ms, and now i get the same behaviour in chrome and firefox (the loading indicator is not shown)
https://stackblitz.com/edit/github-smnznp-pcfnbz?file=package.json,src%2Fapp.tsx

@brophdawg11
Copy link
Contributor

This is resolved by #11838 and will be available in the next release 👍

@brophdawg11 brophdawg11 added the awaiting release This issue have been fixed and will be released soon label Jul 25, 2024
@brophdawg11 brophdawg11 removed their assignment Jul 25, 2024
Copy link
Contributor

🤖 Hello there,

We just published version 6.26.0-pre.0 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

github-actions bot commented Aug 1, 2024

🤖 Hello there,

We just published version 6.26.0 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@brophdawg11 brophdawg11 removed the awaiting release This issue have been fixed and will be released soon label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants