-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Begin usage of operator-framework APIs #767
Begin usage of operator-framework APIs #767
Conversation
@bcrochet sorry for the extra ping, but is this ready for review? I believe you may have mentioned something about this failing go test in standup, but I can't recall what it was. |
Waiting on this: operator-framework/api#255 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few small things
certification/internal/policy/operator/validate_operator_bundle.go
Outdated
Show resolved
Hide resolved
The operator-framework API[1] has lots of bundle manipulation tools that we can leverage to make our own code simpler. This begins the journey of leveraging those APIs. This removes a good bit of code that we get from the library. [1] https://github.com/operator-framework/api Signed-off-by: Brad P. Crochet <brad@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: acornett21, bcrochet, komish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The operator-framework API[1] has lots of bundle manipulation tools
that we can leverage to make our own code simpler. This begins the
journey of leveraging those APIs. This removes a good bit of code
that we get from the library.
[1] https://github.com/operator-framework/api
Signed-off-by: Brad P. Crochet brad@redhat.com