Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix circular dependencies by making ofrak_angr and ofrak_capstone optional for ofrak_core tests #420

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
fab366d
Move internal "forward" dependencies into `requirements-test.txt`
ANogin Feb 12, 2024
5cad09d
Revert "Move internal "forward" dependencies into `requirements-test.…
ANogin May 29, 2024
a36538c
Merge remote-tracking branch 'origin/master' into bugfix/circular_dep…
ANogin May 29, 2024
be3608a
Fix the circular dependency issue
ANogin May 29, 2024
f375f7d
Use an alternative approach to fix the issue
ANogin May 29, 2024
986aaa0
Alternative more localized fix that is messy in its own way
ANogin Jul 4, 2024
b7e447d
Update Makefile
whyitfor Aug 20, 2024
4d7f42f
Support `application/vnd.android.package-archive` mime type for APKs …
ANogin Jun 4, 2024
c384126
Fix an issue with parallel tests potentially clashing (#468)
ANogin Jun 6, 2024
c0f5017
Use GzipFile python unpacker for speed, fall back on pigz if needed (…
ANogin Jun 6, 2024
724936f
Fix Ghidra serializing negative 64-bit addresses (#474)
rbs-afflitto Jun 7, 2024
9f76ed3
Do not run Ghidra auto-analysis on import (#473)
rbs-afflitto Jun 7, 2024
aa0d34b
resourceData doesn't exist if the file is chunked (#478)
dannyp303 Jun 18, 2024
12e5c76
Add install step for gui (#481)
kmjones42 Jul 8, 2024
b97ef46
Make the log file name configurable and include timestamp by default …
ANogin Jul 9, 2024
38ad4ee
Use temporary output directory for `test_function_replacement_modifie…
alchzh Jul 17, 2024
fa276de
Use `ctypes` for entropy calculation (partially reverts #150) (#483)
alchzh Jul 22, 2024
0b5d99c
Add license check to OFRAK (#479)
rbs-jacob Jul 23, 2024
2848ebd
Remove workflow caching steps (#490)
rbs-jacob Aug 15, 2024
7352b68
Support GZIP trailing bytes without stdlib; compress with pigz (#485)
alchzh Aug 15, 2024
2d89436
Add SHELL instruction to build_image.py (#489)
Ivanov1ch Aug 16, 2024
73a8691
Maybe this is a better way?
ANogin Aug 20, 2024
99dae7d
Merge remote-tracking branch 'origin/master' into bugfix/circular_dep…
ANogin Aug 20, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ofrak_core/requirements-test.txt
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,4 @@ pytest-cov
pytest-xdist
requests
fun-coverage==0.2.0
importlib-resources # Needed because of https://github.com/redballoonsecurity/ofrak/issues/398
7 changes: 1 addition & 6 deletions ofrak_core/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -83,12 +83,7 @@ def read_requirements(requirements_path):
+ read_requirements("requirements.txt"),
extras_require={
"docs": read_requirements("requirements-docs.txt"),
"test": [
"importlib-resources", # Needed because of https://github.com/redballoonsecurity/ofrak/issues/398
"ofrak_angr~=1.0",
"ofrak_capstone~=1.0",
]
+ read_requirements("requirements-test.txt"),
"test": read_requirements("requirements-test.txt"),
"non-pypi": read_requirements("requirements-non-pypi.txt"),
},
author="Red Balloon Security",
Expand Down
4 changes: 2 additions & 2 deletions ofrak_core/test_ofrak/components/test_patch_from_source.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@

from ofrak_patch_maker.toolchain.llvm_12 import LLVM_12_0_1_Toolchain

import ofrak_angr
import ofrak_capstone
ofrak_angr = pytest.importorskip("ofrak_angr")
ofrak_capstone = pytest.importorskip("ofrak_capstone")
from ofrak import OFRAKContext, Resource, ResourceAttributeValueFilter, ResourceFilter
from ofrak.core import (
Allocatable,
Expand Down
2 changes: 1 addition & 1 deletion ofrak_core/test_ofrak/components/test_symbolic_analysis.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

import pytest

import ofrak_angr
ofrak_angr = pytest.importorskip("ofrak_angr")
from ofrak import OFRAKContext, Resource, ResourceFilter
from ofrak.core import (
ElfSymbolType,
Expand Down