Bugfix: Only list discovered components in the GUI #313
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One sentence summary of this PR (This should go in the CHANGELOG!)
Link to Related Issue(s)
Previously the GUI backend server used an
OFRAKEnvironment
object to get the list of components offered to the user to run. However this includes components from all installed OFRAK packages, including ones that weren't discovered as part of spinning up the server. So if the user selected one of these components, they would get an error.Additionally, if an OFRAK package was installed without all of its dependencies, any import errors could be avoided by not importing/discovering the package. However since getting the component list through the
OFRAKEnvironment
always imports all installed modules, a user could not avoid getting import errors for such installed, incomplete, and unused packages when using the OFRAK GUI.Please describe the changes in your request.
OFRAKContext
'sComponentLocator
to get componentsComponentLocator
filtersOFRAKContext
methodget_all_tags
, replace it with the call it wrappedResourceTag.all_tags
Anyone you think should look at this, specifically?
@rbs-jacob