[Scoped] Symfony Polyfills are incorrectly prefixed

[mkrauser]

Bug Report

Subject	Details
Rector version	e.g. v0.9.29
Installed as	prefixed Rector

I got an exception, that the function get_debug_type is not defined. I tracked it down to the symfony polyfills incorrectly being prefixed.

The only solution I found to fix this, is to whitelist all bootstrap.php files and bootstrap80.php files within the polyfills. whitelist-global-functions does not work. This might also be an issue within php-scoper itself.

Here's the polyfill for get_debug_type defined: https://github.com/rectorphp/rector-prefixed/blob/f907c6d2101d9e34d027f59a43e5efa1db76790e/vendor/symfony/polyfill-php80/bootstrap.php#L50

If rector is executed on PHP < 8.0, and get_debug_type is called (either by rector- or by vendor-code), the function is undefined due to the namespace added here.

[TomasVotruba]

Hi,

thanks for reporting!
Could you link to the code in https://github.com/rectorphp/rector-prefixed ?

How can we reproduce with rector/rector-prefixed?

[mkrauser]

Of course. I added it to the report

[TomasVotruba]

There is no get_debug_type in the linked file.

[TomasVotruba]

We'll need a reproducible repository on Github to solve this one

[mkrauser]

We'll need a reproducible repository on Github to solve this one

I've updated the description and I'll try to implement a failing demo

[TomasVotruba]

Thanks!
Now it's hard to follow where the reply is. Could you use comments for next replies to keep the context from up to bottom?

[mkrauser]

Of course, I just wanted to keep everything in one place.
It might take a few days before I find time to do that.

[TomasVotruba]

This looks like bug in php-scoper, as the function itself is prefixed correctly:

// bug
if (!\function_exists('get_debug_type')) {
    function get_debug_type($value) : string
    {
        // correct
        return \RectorPrefix20210218\Symfony\Polyfill\Php80\Php80::get_debug_type($value);
    }
}

There are 2 ways to fix it:

• Right in php-scoper (better, but could take weeks to merge)
• Add a custom patcher callback in our scoper.php to handle it:

  rector/scoper.php

  Line 29 in 652459a

  ScoperOption::PATCHERS => [

[mkrauser]

There is already an issue in php-scoper for this: humbug/php-scoper#440

[TomasVotruba]

Closing here then, thanks for reference