-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RCOCOA-1874: Add support for lexicographical comparison for string queries #8557
Conversation
ad12214
to
1fc78b2
Compare
1fc78b2
to
4fd7d7a
Compare
4fd7d7a
to
03b9db1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is silently ignoring case-insensitive modifiers on comparison operators (e.g. You appear to have modified the generated test files directly rather than modify the template files. |
Case sensitive operations are not supported for |
I don't think we should support case-insensitive comparisons, but we need to report an error rather than silently doing the wrong thing. |
03b9db1
to
f1058b6
Compare
@tgoyne solved comments |
f1058b6
to
c0b16f1
Compare
Added support for string comparison queries, which allows building string
queries with the following operators (
>
,>=
,<
,<=
).(#8008).