RCOCOA-2395: Code sign our published xcframeworks #8637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dianaafanador3
force-pushed
the
dp/sign-xcframework
branch
2 times, most recently
from
2800058
to
4bae45c
Compare
|
It looks like this is signed with your personal team certificate (team 74HX4QV25A rather than QX5CR2FTN2). We should probably update the certificates. |
tgoyne
reviewed
Jun 26, 2024
.github/workflows/master-push.yml
Outdated
Comment on lines
194
to
209
| # create variables | ||
| CERTIFICATE_PATH=$RUNNER_TEMP/build_certificate.p12 | ||
| KEYCHAIN_PATH=$RUNNER_TEMP/app-signing.keychain-db | ||
|
|
||
| # import certificate and provisioning profile from secrets | ||
| echo -n "$DEVELOPMENT_CERTIFICATE_BASE64" | base64 --decode -o $CERTIFICATE_PATH | ||
|
|
||
| # create temporary keychain | ||
| security create-keychain -p "$KEYCHAIN_PASSWORD" $KEYCHAIN_PATH | ||
| security set-keychain-settings -lut 21600 $KEYCHAIN_PATH | ||
| security unlock-keychain -p "$KEYCHAIN_PASSWORD" $KEYCHAIN_PATH | ||
|
|
||
| # import certificate to keychain | ||
| security import $CERTIFICATE_PATH -P "$P12_PASSWORD" -A -t cert -f pkcs12 -k $KEYCHAIN_PATH | ||
| security set-key-partition-list -S apple-tool:,apple: -k "$KEYCHAIN_PASSWORD" $KEYCHAIN_PATH | ||
| security list-keychain -d user -s $KEYCHAIN_PATH |
There was a problem hiding this comment.
This should all be a shell script which is invoked. The only thing which should ever be in the GHA yaml files are just the GHA configuration, and not the actual build steps.
dianaafanador3
force-pushed
the
dp/sign-xcframework
branch
from
8c17b37
to
031ea29
Compare
tgoyne
approved these changes
Jul 13, 2024
Naveen-C-Ramachandrappa
approved these changes
Jul 21, 2024
dianaafanador3
force-pushed
the
dp/sign-xcframework
branch
4 times, most recently
from
9543b67
to
4674cb5
Compare
dianaafanador3
force-pushed
the
dp/sign-xcframework
branch
from
4674cb5
to
0cf4890
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code sign our published xcframeworks in Github actions.
You can verify the generated release package in this action run.
https://github.com/realm/realm-swift/actions/runs/9600027436