Fix README to better reflect reality #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agjohnson
reviewed
Jun 9, 2021
There was a problem hiding this comment.
Good to have the doc better reflect reality, however that also means that we currently only have a loose plan to change these images at some point in the future. This work is not currently on our near/middle term roadmap because it's a high effort and probably fairly low value outside operations improvements.
This reverts commit 884da27.
astrojuanlu
changed the title
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though we updated the README in #137, we never updated the actual images on the service:
https://github.com/readthedocs/readthedocs.org/blob/75955e153d8a6e56d001008b6b3855455b5abeb0/readthedocs/settings/base.py#L501-L506
Also, as @humitos mentioned in #170 (review) and other places, we don't intend to update these images anymore until we implement the new ones.(Edit: I toned this down, see reviews)And finally, on #159 we added support for Python 3.9 in our
testingimage, but we didn't update the README to reflect that.