Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing != 7.0 #177

Closed
DrewDevereux opened this issue Sep 16, 2021 · 5 comments · Fixed by #166
Closed

testing != 7.0 #177

DrewDevereux opened this issue Sep 16, 2021 · 5 comments · Fixed by #166

Comments

@DrewDevereux
Copy link

The README.md states that readthedocs/build:testing == readthedocs/build:7.0, but this is not the case. :7.0 contains python 3.9, but :testing does not:

me@mine:~$ docker run -ti readthedocs/build:testing bash
docs@38ccaab061da:/$ python3.8 --version
Python 3.8.6
docs@38ccaab061da:/$ python3.9 --version
bash: python3.9: command not found
docs@38ccaab061da:/$
@humitos
Copy link
Member

humitos commented Sep 16, 2021

Hi @DrewDevereux! These images are for internal Read the Docs usage and for development. They are tagged in our servers and locally but maybe wrong in Docker Hub.

Besides we are changing our structure and none of these images are going to be used anymore.

What do you want to use these images for?

@astrojuanlu
Copy link
Contributor

astrojuanlu commented Sep 16, 2021

I thought we had addressed the inaccuracies of the README in #172, however I am now confused as well.

For the record, I confirm that testing doesn't have Python 3.9, but 7.0 does.

@DrewDevereux
Copy link
Author

DrewDevereux commented Sep 16, 2021

Hi @humitos,
Two reasons:

  1. We build our docs in our CI pipeline, in order to be confident that they will build correctly on RTD, so it makes sense for our CI pipeline build process to mimic as closely as possible the RTD build process. Therefore our CI pipeline builds our docs in a readthedocs/build container.
  2. We embed UML diagrams in our docs using sphinxcontrib-plantuml, which needs PlantUML to be installed. Your docker images are a very convenient way to get that.

@humitos
Copy link
Member

humitos commented Sep 16, 2021

We build our docs in our CI pipeline, in order to be confident that they will build correctly on RTD, so it makes sense for our CI pipeline build process to mimic as closely as possible the RTD build process. Therefore our CI pipeline builds our docs in a readthedocs/build container

Why not using "Pull Request builders" instead of mimic Read the Docs? See https://blog.readthedocs.com/pull-request-builder-general-availability/

@DrewDevereux
Copy link
Author

That looks sensational. I'll give it a go, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants