Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: opt picker time panel hover to show as placeholder #858

Merged
merged 3 commits into from
Aug 8, 2024

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Aug 8, 2024

Copy link

vercel bot commented Aug 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
picker ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2024 7:13am

Copy link

codecov bot commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 78.37838% with 8 lines in your changes missing coverage. Please review.

Project coverage is 95.16%. Comparing base (e2db7d2) to head (2c82e44).
Report is 6 commits behind head on master.

Files Patch % Lines
src/PickerPanel/TimePanel/TimePanelBody/index.tsx 81.25% 6 Missing ⚠️
...PickerPanel/TimePanel/TimePanelBody/TimeColumn.tsx 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #858      +/-   ##
==========================================
- Coverage   95.41%   95.16%   -0.25%     
==========================================
  Files          64       64              
  Lines        2680     2709      +29     
  Branches      727      757      +30     
==========================================
+ Hits         2557     2578      +21     
- Misses        120      128       +8     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shmdhussain
Copy link

This is causing issues when the component is used alone see this code sandbox:

you will see the errors in the console once you hover over the time panel column values.

Error screenshot:

Screenshot 2024-08-27 at 21 32 24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants