Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add comments and warnings for the deprecated property defaultPic… #661

Merged
merged 2 commits into from
Sep 7, 2023

Conversation

zbw-zbw
Copy link
Contributor

@zbw-zbw zbw-zbw commented Jul 25, 2023

Add comments and warnings for the deprecated property defaultPickerValue

about:
issues
ant-design-pr

@vercel
Copy link

vercel bot commented Jul 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
picker ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2023 7:50am

Copy link
Contributor

@Wxh16144 Wxh16144 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zbw-zbw
Copy link
Contributor Author

zbw-zbw commented Jul 25, 2023

可以参考 d6c0e61#diff-aa79defbca4231fbbbc7a7fce45993745255dad38aeaf51d0c6c747fd89b759d 补充一个 测试用例, 3Q~

好的,我补充下

@zbw-zbw
Copy link
Contributor Author

zbw-zbw commented Jul 25, 2023

可以参考 d6c0e61#diff-aa79defbca4231fbbbc7a7fce45993745255dad38aeaf51d0c6c747fd89b759d 补充一个 测试用例, 3Q~

已补充哈~

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #661 (d5f9a9e) into master (f699375) will increase coverage by 0.00%.
Report is 6 commits behind head on master.
The diff coverage is 100.00%.

❗ Current head d5f9a9e differs from pull request most recent head d62d8c9. Consider uploading reports for the commit d62d8c9 to get more accurate results

@@           Coverage Diff           @@
##           master     #661   +/-   ##
=======================================
  Coverage   99.04%   99.05%           
=======================================
  Files          55       56    +1     
  Lines        2416     2427   +11     
  Branches      716      720    +4     
=======================================
+ Hits         2393     2404   +11     
  Misses         21       21           
  Partials        2        2           
Files Changed Coverage Δ
src/Picker.tsx 100.00% <100.00%> (ø)
src/PickerPanel.tsx 100.00% <100.00%> (ø)
src/RangePicker.tsx 99.27% <100.00%> (+<0.01%) ⬆️
src/hooks/useRangeOpen.ts 100.00% <100.00%> (ø)
src/utils/dateUtil.ts 100.00% <100.00%> (ø)
src/utils/getClearIcon.tsx 100.00% <100.00%> (ø)
tests/util/commonUtil.tsx 93.10% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zbw-zbw
Copy link
Contributor Author

zbw-zbw commented Jul 26, 2023

可以参考 d6c0e61#diff-aa79defbca4231fbbbc7a7fce45993745255dad38aeaf51d0c6c747fd89b759d 补充一个 测试用例, 3Q~

已补充哈~

@Wxh16144 大佬 还有什么要调整的吗?

@zbw-zbw zbw-zbw closed this Jul 26, 2023
@zbw-zbw zbw-zbw reopened this Jul 26, 2023
@zbw-zbw
Copy link
Contributor Author

zbw-zbw commented Sep 6, 2023

@yoyo837 大佬你好 这个 pr 可以合并了吧?我看都 review 过了😊

@zbw-zbw
Copy link
Contributor Author

zbw-zbw commented Sep 6, 2023

哦对我 antd 那边还有一个相关的 issue 还没通过 得等那个一起
ant-design/ant-design#43781

@afc163 afc163 requested a review from zombieJ September 7, 2023 01:05
@zombieJ zombieJ merged commit c23b2b6 into react-component:master Sep 7, 2023
13 checks passed
@zbw-zbw zbw-zbw deleted the fix/defaultPickerValue branch September 7, 2023 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants