Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove defaultPickerValue related content #656

Conversation

zbw-zbw
Copy link
Contributor

@zbw-zbw zbw-zbw commented Jul 18, 2023

fix #41974

@vercel
Copy link

vercel bot commented Jul 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
picker ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2023 11:20am

@zbw-zbw
Copy link
Contributor Author

zbw-zbw commented Jul 18, 2023

@zombieJ 大佬 有空也审批下这个 pr

@afc163
Copy link
Member

afc163 commented Jul 18, 2023

defaultPickerValue 应该还是有用的,只是废弃了,我看测试用例里还有相关代码,不应该移除。

@zbw-zbw
Copy link
Contributor Author

zbw-zbw commented Jul 18, 2023

defaultPickerValue 应该还是有用的,只是废弃了,我看测试用例里还有相关代码,不应该移除。

这样吗 首先我理解废弃了的属性没啥用了吧 只是没清理掉相关代码而已?因为我看到源码里面也是有注释写着过期属性…不确定还有什么作用哈哈哈😆

其次这个属性在用户(使用者)角度设置是无效的,感觉不应该暴露出来?会觉得是个bug 大佬看看我另一个 pr

ant-design/ant-design#43620

@zbw-zbw zbw-zbw closed this Sep 6, 2023
@zbw-zbw zbw-zbw deleted the fix/remove_legacy_props_defaultPickerValue branch September 7, 2023 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DatePicker - defaultPickerValue doesn't display
2 participants