Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Enable rendering a different element #589

Open
jsbrain opened this issue Jan 23, 2023 · 2 comments
Open

Feature: Enable rendering a different element #589

jsbrain opened this issue Jan 23, 2023 · 2 comments

Comments

@jsbrain
Copy link

jsbrain commented Jan 23, 2023

Due to accessibility and UX reasons I want to render actual link elements instead of li elements.

This can currently only achieved by using <Menu.Item> which gives me an error notification, that it is deprecated and items should be used.

But with the items prop it seems to me there's no way to achieve the same. I guess I could abuse the label prop for that matter by making it full size and reconstruct the default layout of said element so it works the same way with the icon and what not.

Ideally, I'd want an option to change the type of the list element that's being rendered.

@MadCcc
Copy link
Member

MadCcc commented Mar 8, 2023

Render <a> in label would be ok.

@jsbrain
Copy link
Author

jsbrain commented Mar 8, 2023

Anything would probably be ok. My point is, AFAIK there is no option to specify what element to render at all.

Or am I wrong here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants