From 2d8335c4b2873dd346051df8ca1136dd1af172b9 Mon Sep 17 00:00:00 2001 From: dominictb Date: Fri, 6 Sep 2024 09:19:24 +0700 Subject: [PATCH 1/2] fix: view your subscription link does not navigate to subscription page --- .../upgrade/WorkspaceUpgradePage.tsx | 33 +++++++++++++++---- 1 file changed, 26 insertions(+), 7 deletions(-) diff --git a/src/pages/workspace/upgrade/WorkspaceUpgradePage.tsx b/src/pages/workspace/upgrade/WorkspaceUpgradePage.tsx index 673b77d9c9a1..139db411acc4 100644 --- a/src/pages/workspace/upgrade/WorkspaceUpgradePage.tsx +++ b/src/pages/workspace/upgrade/WorkspaceUpgradePage.tsx @@ -32,6 +32,19 @@ function WorkspaceUpgradePage({route}: WorkspaceUpgradePageProps) { const canPerformUpgrade = !!feature && !!policy && PolicyUtils.isPolicyAdmin(policy); const isUpgraded = React.useMemo(() => PolicyUtils.isControlPolicy(policy), [policy]); + const goBack = useCallback(() => { + if (!feature) { + return; + } + switch (feature.id) { + case CONST.UPGRADE_FEATURE_INTRO_MAPPING.reportFields.id: + case CONST.UPGRADE_FEATURE_INTRO_MAPPING.rules.id: + return Navigation.navigate(ROUTES.WORKSPACE_MORE_FEATURES.getRoute(policyID)); + default: + return route.params.backTo ? Navigation.navigate(route.params.backTo) : Navigation.goBack(); + } + }, [feature, policyID, route.params.backTo]); + const upgradeToCorporate = () => { if (!canPerformUpgrade) { return; @@ -47,14 +60,10 @@ function WorkspaceUpgradePage({route}: WorkspaceUpgradePageProps) { switch (feature.id) { case CONST.UPGRADE_FEATURE_INTRO_MAPPING.reportFields.id: Policy.enablePolicyReportFields(policyID, true, true); - return Navigation.navigate(ROUTES.WORKSPACE_MORE_FEATURES.getRoute(policyID)); case CONST.UPGRADE_FEATURE_INTRO_MAPPING.rules.id: Policy.enablePolicyRules(policyID, true, true); - return Navigation.navigate(ROUTES.WORKSPACE_MORE_FEATURES.getRoute(policyID)); - default: - return route.params.backTo ? Navigation.navigate(route.params.backTo) : Navigation.goBack(); } - }, [feature, policyID, route.params.backTo]); + }, [feature, policyID]); useEffect(() => { const unsubscribeListener = navigation.addListener('blur', () => { @@ -79,11 +88,21 @@ function WorkspaceUpgradePage({route}: WorkspaceUpgradePageProps) { > (isUpgraded ? Navigation.dismissModal() : Navigation.goBack())} + onBackButtonPress={() => { + if (isUpgraded) { + Navigation.dismissModal(); + } else { + Navigation.goBack(); + } + goBack(); + }} /> {isUpgraded && ( Navigation.dismissModal()} + onConfirmUpgrade={() => { + Navigation.dismissModal(); + goBack(); + }} policyName={policy.name} /> )} From e9ec6827974b5f28307a06865308131dcccb0212 Mon Sep 17 00:00:00 2001 From: dominictb Date: Fri, 6 Sep 2024 09:30:08 +0700 Subject: [PATCH 2/2] fix lint --- src/pages/workspace/upgrade/WorkspaceUpgradePage.tsx | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/pages/workspace/upgrade/WorkspaceUpgradePage.tsx b/src/pages/workspace/upgrade/WorkspaceUpgradePage.tsx index 139db411acc4..0cdb15e33ac9 100644 --- a/src/pages/workspace/upgrade/WorkspaceUpgradePage.tsx +++ b/src/pages/workspace/upgrade/WorkspaceUpgradePage.tsx @@ -60,8 +60,11 @@ function WorkspaceUpgradePage({route}: WorkspaceUpgradePageProps) { switch (feature.id) { case CONST.UPGRADE_FEATURE_INTRO_MAPPING.reportFields.id: Policy.enablePolicyReportFields(policyID, true, true); + break; case CONST.UPGRADE_FEATURE_INTRO_MAPPING.rules.id: Policy.enablePolicyRules(policyID, true, true); + break; + default: } }, [feature, policyID]);