-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEA] pandas DatetimeIndex.indexer_between_time #15380
Comments
Thanks, @raybellwaves! I think this could be implemented in terms of the existing datetime methods. For instance, This would make a great contribution if you (or anyone else) is interested in taking it on! |
Hi @shwina, I would like to take up on this issue if no one has started working on this. |
Fantastic! No one has yet so please feel free to take it on. Don't hesitate to reach out to us either here or on the RAPIDS slack if you have any questions! |
@srinivasyadav18, still working on this? |
@er-eis Yes, I have been trying it for few days, but could not make much progress. Please feel free to work on it! |
sounds good, i'll take this then! |
I watched @shwina's GTC talk (https://register.nvidia.com/flow/nvidia/gtcs24/attendeeportaldigital/page/sessioncatalog/session/1695219773174001AmnA thanks Ashwin I really enjoyed it!)
Is your feature request related to a problem? Please describe.
No. I just noticed there wasn't an issue for
DatetimeIndex.indexer_between_time
. I also enjoyed the user experience that%%cudf.pandas.profile
points users to raise issues to highlight pandas API that falls back to CPU (https://github.com/rapidsai/cudf/blob/branch-24.06/python/cudf/cudf/pandas/profiler.py#L300).Describe the solution you'd like
Describe alternatives you've considered
There may be a cudf work around in the meantime for a user who needs indexer_between_time that could be captured at https://docs.rapids.ai/api/cudf/stable/cudf_pandas/
Additional context
Could create a new issue template with the "pandas" label (https://github.com/rapidsai/cudf/issues?q=is%3Aopen+is%3Aissue+label%3Apandas) to be used at https://github.com/rapidsai/cudf/blob/branch-24.06/python/cudf/cudf/pandas/profiler.py#L297fixed a bug at #15381The text was updated successfully, but these errors were encountered: