diff --git a/cpp/src/reductions/segmented_reductions.cpp b/cpp/src/reductions/segmented_reductions.cpp index 04a83217469..6ccc87291cc 100644 --- a/cpp/src/reductions/segmented_reductions.cpp +++ b/cpp/src/reductions/segmented_reductions.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2022, NVIDIA CORPORATION. + * Copyright (c) 2022-2023, NVIDIA CORPORATION. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -88,7 +88,7 @@ struct segmented_reduce_dispatch_functor { col, offsets, output_dtype, null_handling, init, stream, mr); default: CUDF_FAIL("Unsupported aggregation type."); - // TODO: Add support for compound_ops + // TODO: Add support for compound_ops. GH #10432 } } }; diff --git a/cpp/src/reductions/simple_segmented.cuh b/cpp/src/reductions/simple_segmented.cuh index 321ff0e7410..418a8c5a01e 100644 --- a/cpp/src/reductions/simple_segmented.cuh +++ b/cpp/src/reductions/simple_segmented.cuh @@ -1,5 +1,5 @@ /* - * Copyright (c) 2022, NVIDIA CORPORATION. + * Copyright (c) 2022-2023, NVIDIA CORPORATION. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -73,8 +73,6 @@ std::unique_ptr simple_segmented_reduction( rmm::cuda_stream_view stream, rmm::mr::device_memory_resource* mr) { - // TODO: Rewrites this function to accept a pair of iterators for start/end indices - // to enable `2N` type offset input. // reduction by iterator auto dcol = cudf::column_device_view::create(col, stream); auto simple_op = Op{}; @@ -99,7 +97,6 @@ std::unique_ptr simple_segmented_reduction( make_fixed_width_column(result_type, num_segments, mask_state::UNALLOCATED, stream, mr); auto outit = result->mutable_view().template begin(); - // TODO: Explore rewriting null_replacing_element_transformer/element_transformer with nullate if (col.has_nulls()) { auto f = simple_op.template get_null_replacing_element_transformer(); auto it = thrust::make_transform_iterator(dcol->pair_begin(), f);