Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix registry urls on generate missing images list and adds registry info to digests #467

Merged
merged 7 commits into from
Aug 19, 2024

Conversation

tashima42
Copy link
Contributor

@tashima42 tashima42 commented Aug 9, 2024

Problem: The --registry flag wasn't working because the registry URL was hardcoded in a function
Solution: Use the registry info to get the correct registry information

Other updates:

  • Adds the registry information to docker digests
  • Adds the verbose flag --verbose, -V
  • Adds the ecm log package which only prints info to sdout if verbose is enabled.

@tashima42 tashima42 changed the title fix registry urls on generate missing images list fix registry urls on generate missing images list and adds registry info to digests Aug 14, 2024
log/log.go Outdated Show resolved Hide resolved
release/rancher/rancher.go Outdated Show resolved Hide resolved
release/rancher/rancher.go Outdated Show resolved Hide resolved
@tashima42 tashima42 merged commit 207fd7d into rancher:master Aug 19, 2024
2 checks passed
@tashima42 tashima42 deleted the fix-registry-missing-images branch August 19, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants