Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config validator, custom location and flag #462

Merged
merged 14 commits into from
Aug 7, 2024
Merged

config validator, custom location and flag #462

merged 14 commits into from
Aug 7, 2024

Conversation

tashima42
Copy link
Contributor

@tashima42 tashima42 commented Aug 2, 2024 •
edited
Loading

  • adds a config validator
  • customizable config location
  • updates default flags
  • adds an option to input the config using a string

With these changes, automated tests will force us to maintain a valid example config and the generated example config won't replace the current one.

briandowns
briandowns reviewed Aug 2, 2024
View reviewed changes
cmd/release/cmd/root.go Outdated Show resolved Hide resolved
@tashima42 tashima42 self-assigned this Aug 2, 2024
@tashima42 tashima42 mentioned this pull request Aug 2, 2024
Merged
@tashima42 tashima42 removed the request for review from briandowns August 6, 2024 13:26
briandowns
briandowns previously requested changes Aug 6, 2024
View reviewed changes
cmd/release/cmd/root.go Outdated Show resolved Hide resolved
cmd/release/cmd/root.go Outdated Show resolved Hide resolved
nicholasSUSE
nicholasSUSE requested changes Aug 6, 2024
View reviewed changes
cmd/release/cmd/root.go Outdated Show resolved Hide resolved
@nicholasSUSE nicholasSUSE self-requested a review August 6, 2024 17:34
@tashima42 tashima42 merged commit 5803f67 into rancher:master Aug 7, 2024
2 checks passed
@tashima42 tashima42 deleted the update-config branch August 7, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brooksn brooksn brooksn approved these changes

@nicholasSUSE nicholasSUSE nicholasSUSE approved these changes

@rafaelbreno rafaelbreno Awaiting requested review from rafaelbreno

@briandowns briandowns Awaiting requested review from briandowns

Assignees

@tashima42 tashima42

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tashima42 @brooksn @briandowns @nicholasSUSE