Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpacker::Digests.lookup issue #151

Closed
towry opened this issue Mar 2, 2017 · 3 comments
Closed

Webpacker::Digests.lookup issue #151

towry opened this issue Mar 2, 2017 · 3 comments
Assignees
Labels

Comments

@towry
Copy link

towry commented Mar 2, 2017

The content of digests.json file that my project generated in production environment is:

{"conversation":["conversation-4ab9768dd0430c0910c6.js","conversation-4ab9768dd0430c0910c6.js.map"],"hello_react":"hello_react-4ab9768dd0430c0910c6.js","packs-bundle":"packs-bundle-4ab9768dd0430c0910c6.js"}

So the lookup method will return an array string instead of the correct digested filename if I want to use conversation script.

@guilleiguaran guilleiguaran self-assigned this Mar 2, 2017
@ylt6
Copy link

ylt6 commented Mar 2, 2017

I will take this

@gauravtiwari
Copy link
Member

gauravtiwari commented Mar 3, 2017

@towry You are passing sourcemap option in production right?

devtool: 'sourcemap',
new webpack.optimize.UglifyJsPlugin({
      sourceMap: true,
 }),

After #153 this should be fine as it generates a flat manifest.

{
  "application.js": "/packs/application-61c89ec4d430372bfdbf.js",
  "application.js.map": "/packs/application-61c89ec4d430372bfdbf.js.map",
  "clock.png": "/packs/clock-fc31531de5cc3518c7c658d5b83faa72.png",
  "counter.css": "/packs/counter-11f770942f5b77a0442f.css",
  "counter.css.map": "/packs/counter-11f770942f5b77a0442f.css.map",
  "counter.js": "/packs/counter-0bd141f6d9360cf4a7f5.js",
  "counter.js.map": "/packs/counter-0bd141f6d9360cf4a7f5.js.map",
  "hello_react.css": "/packs/hello_react-11f770942f5b77a0442f.css",
  "hello_react.css.map": "/packs/hello_react-11f770942f5b77a0442f.css.map",
  "hello_react.js": "/packs/hello_react-447e04580529cf7a332b.js",
  "hello_react.js.map": "/packs/hello_react-447e04580529cf7a332b.js.map",
  "lacuna-webfont.eot": "/packs/lacuna-webfont-54c0d12c6ab265792f0d8cfd81e481e4.eot",
  "lacuna-webfont.svg": "/packs/lacuna-webfont-4291fc75d6240959b4abe83809c90350.svg",
  "lacuna-webfont.ttf": "/packs/lacuna-webfont-1acb63487c4a72f7fd2e545d2e0090e2.ttf",
  "lacuna-webfont.woff": "/packs/lacuna-webfont-0eb6add367ef5fc69c4569894525bd52.woff"
}

@gauravtiwari
Copy link
Member

@towry We can close this one. #153 is merged

@dhh dhh closed this as completed Mar 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants