From 7bcf6e5067d5ac9536511403eea749fb89243d29 Mon Sep 17 00:00:00 2001 From: Jevon Wright Date: Mon, 24 Jul 2017 17:11:23 +1200 Subject: [PATCH] Update Changelog and README for Webpacker on Windows Do not generate batch files when installing --- CHANGELOG.md | 2 ++ README.md | 11 +++++++++++ lib/install/bin/webpack-dev-server.bat.tt | 1 - lib/install/bin/webpack.bat.tt | 1 - 4 files changed, 13 insertions(+), 2 deletions(-) delete mode 100755 lib/install/bin/webpack-dev-server.bat.tt delete mode 100755 lib/install/bin/webpack.bat.tt diff --git a/CHANGELOG.md b/CHANGELOG.md index 6f6ceaa85..efb60dfaf 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -11,6 +11,8 @@ host: localhost ``` +- On Windows, `ruby bin/webpacker` and `ruby bin/webpacker-dev-server` will now bypass yarn, and execute via `node_modules/.bin` directly - [#583](https://github.com/rails/webpacker/pull/583) + ### Breaking changes - Add `compile` option to `config/webpacker.yml` for configuring lazy compilation of packs when a file under tracked paths is changed [#503](https://github.com/rails/webpacker/pull/503). To enable expected behavior, update `config/webpacker.yml`: diff --git a/README.md b/README.md index 3ef6fa599..e26e36cc9 100644 --- a/README.md +++ b/README.md @@ -1185,6 +1185,17 @@ bundle config --delete bin ./bin/rails app:update:bin # or rails app:update:bin ``` +##### Running Webpack on Windows + +If you are running Webpack on Windows, your command shell may not be able to interpret the preferred interpreter +for the scripts generated in `bin/webpack` and `bin/webpack-dev-server`. Instead you'll want to run the scripts +manually with Ruby: + +``` +C:\path>ruby bin\webpack +C:\path>ruby bin\webpack-dev-server +``` + ## Wishlist - HMR - [#188](https://github.com/rails/webpacker/issues/188) diff --git a/lib/install/bin/webpack-dev-server.bat.tt b/lib/install/bin/webpack-dev-server.bat.tt deleted file mode 100755 index c8ec8b2e2..000000000 --- a/lib/install/bin/webpack-dev-server.bat.tt +++ /dev/null @@ -1 +0,0 @@ -@ruby bin\webpack-dev-server %* diff --git a/lib/install/bin/webpack.bat.tt b/lib/install/bin/webpack.bat.tt deleted file mode 100755 index 857b3e080..000000000 --- a/lib/install/bin/webpack.bat.tt +++ /dev/null @@ -1 +0,0 @@ -@ruby bin\webpack %*