From 1d41cd40a316f574006a5cccfa76f23de3a8d304 Mon Sep 17 00:00:00 2001 From: Alex Bean Date: Mon, 2 Sep 2024 09:43:21 +0200 Subject: [PATCH] fix: remove extra 0x in outputted text when pop up (#298) * fix: bug: extra 0x in outputted text * fix: test * fix: add 0x when error --- crates/pop-contracts/src/up.rs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/crates/pop-contracts/src/up.rs b/crates/pop-contracts/src/up.rs index ac4d22e4..f4cc65bd 100644 --- a/crates/pop-contracts/src/up.rs +++ b/crates/pop-contracts/src/up.rs @@ -187,7 +187,7 @@ pub async fn upload_smart_contract( .await .map_err(|error_variant| Error::UploadContractError(format!("{:?}", error_variant)))?; if let Some(code_stored) = upload_result.code_stored { - return Ok(format!("0x{:?}", code_stored.code_hash)); + return Ok(format!("{:?}", code_stored.code_hash)); } else { let code_hash: String = upload_exec.code().code_hash().iter().map(|b| format!("{:02x}", b)).collect(); @@ -330,6 +330,7 @@ mod tests { }; let upload_exec = set_up_upload(up_opts).await?; let upload_result = dry_run_upload(&upload_exec).await?; + assert!(!upload_result.code_hash.starts_with("0x0x")); assert!(upload_result.code_hash.starts_with("0x")); Ok(()) } @@ -361,6 +362,7 @@ mod tests { // Only upload a Smart Contract let upload_result = upload_smart_contract(&upload_exec).await?; + assert!(!upload_result.starts_with("0x0x")); assert!(upload_result.starts_with("0x")); //Error when Smart Contract has been already uploaded assert!(matches!(