Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cli list packages #1852

Merged
merged 4 commits into from
Oct 13, 2020
Merged

fix cli list packages #1852

merged 4 commits into from
Oct 13, 2020

Conversation

cosmic-byte
Copy link
Contributor

Description

Fix cli list packages bug

@codecov-io
Copy link

codecov-io commented Oct 12, 2020

Codecov Report

Merging #1852 into master will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1852      +/-   ##
==========================================
+ Coverage   89.49%   89.53%   +0.04%     
==========================================
  Files          62       62              
  Lines        7241     7251      +10     
==========================================
+ Hits         6480     6492      +12     
+ Misses        761      759       -2     
Flag Coverage Δ
#api-python 87.94% <100.00%> (+0.06%) ⬆️
#lambda 92.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/python/quilt3/main.py 57.14% <100.00%> (+1.05%) ⬆️
api/python/tests/test_cli.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90680ec...982bccb. Read the comment docs.

sir-sigurd
sir-sigurd previously approved these changes Oct 12, 2020
Copy link
Member

@sir-sigurd sir-sigurd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but tests are needed.

Copy link
Member

@sir-sigurd sir-sigurd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but needs tests and changelog entry.

api/python/tests/test_cli.py Outdated Show resolved Hide resolved
api/python/tests/test_cli.py Outdated Show resolved Hide resolved
docs/CHANGELOG.md Outdated Show resolved Hide resolved
@cosmic-byte cosmic-byte merged commit bf6ba22 into master Oct 13, 2020
@cosmic-byte cosmic-byte deleted the cli-list-packages branch October 13, 2020 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants